Active crown fire (Scott & Reinhardt 2001) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic roots md bugfix
These changes add new parameters to the fates parameter file. No existing parameters were changed or removed. See issue 753 for details on new parameters.
This needs to be not equal since when in any mode other than no comp or its derivatives, the label will be -999
…to print statements and new file for parameters at barro colorado island panama.
Refactored the do_patch_dynamics check added for SP mode as well as some older duplicate logic checks that can be combined.
Updating the element id from a number to the element parameter name to clarify. Co-authored-by: Charlie Koven <[email protected]>
…ties" This reverts commit 455617d.
This reverts commit a260f31.
Update FATES PFT optical to Majasalmi Bright 2019
We never added the logo that we had decided on a while ago to our GitHub repository, so here it is.
Add logo to front page
move frac_lai and frac_sai calculation outside do ib=1,hlm_numSWb loop
Resolved conflicts: fire/SFMainMod.F90 main/EDPftvarcon.F90 main/EDTypesMod.F90 main/FatesInterfaceMod.F90 parameter_files/fates_params_default.cdl
This and next few commits resolve conflicts missed by git and caught by github
Committing only to get ./manage_externals/checkout_externals to finish
Using existing test: SMS_Lm12_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesFireLightningPopDens
There were two copies of this parameter: a scalar and an array and the model was getting confused when trying to read them
I found references to both currentCohort%active_crown_fire_flg and currentPatch%active_crown_fire_flg and I think the latter is correct and the former incorrect
Calculate required intensity to scorch crown and canopy, then re-calculate rate of spread and fire intensity Fixes: 573 User interface changes?: No Code review:
Fix mistake in equation to solve for phi_wind as part of steps towards calculation of canopy fraction burnt.
To be used as on/off switch. Rm the version that varies by pft.
slevis-lmwg
changed the base branch from
read_lightning_data
to
active_crown_fire
slevis-lmwg
commented
Apr 19, 2022
| ! TODO slevis: Are we missing a -phi_s after the -1? | ||
| ROS_torch = 1._r8 / (54.683_r8 * wind_reduce) * & | ||
| ((60._r8 * passive_crown_FI * currentPatch%fuel_bulkd * eps * q_ig / & | ||
| (heat_per_area * ir * xi) - 1._r8) / (c * beta_ratio**-e))**(1._r8 / b) |
There was a problem hiding this comment.
@jkshuman
commenting out lines 408 and 495 got us past the divide-by-zero in eq 18; however, are we missing a -phi_s term after the -1 or did you omit it intentionally?
There was a problem hiding this comment.
that is for the slope. I meant to add it in as a placeholder with a value of zero as we do not have slope currently. So you can add a parameter "slope_factor" and set it to zero.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR follows in the footsteps of
#573
#572
jkshuman#5
https://github.com/jkshuman/fates/tree/active_crown_Scott_2001
in getting the FATES fire module closer to having an active crown fire parameterization.
Collaborators:
@jkshuman @lmkueppers @pollybuotte @ckoven @glemieux
Expectation of Answer Changes:
At least when
fates_fire_active_crown_fire = 1and active crown fires do occur.Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: