Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cannot remove shortcuts (merge setups instead of chain setups) #1922

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Oct 30, 2024

defineShortcutsSetup are supposed to receive the set of shortcuts and return the new set of shortcuts (based on the received one, possibly removing some). So we have a chain of setups.

The current code does a union of setups, merging all results, breaking the previous semantics (which is more useful and which is reflected by the documentation).

This patch brings back the new behavior, using the new, clean setup syntax.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 5a1e533
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/672246b13d6b7a00081c20a0
😎 Deploy Preview https://deploy-preview-1922--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1922

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1922

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1922

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1922

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1922

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1922

commit: 5a1e533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants