Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup preparser correctly when no addons are used #1951

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

oripka
Copy link
Contributor

@oripka oripka commented Nov 18, 2024

Currently the preparser is only called if addons.length > 0. If no addons are used the preparser does not work. This fixes that issue.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for slidev failed.

Name Link
🔨 Latest commit c5a319d
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/673eacae1182890008b34590

Copy link
Member

@KermanX KermanX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~

Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1951

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1951

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1951

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1951

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1951

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1951

commit: c5a319d

@KermanX KermanX merged commit 11dbbea into slidevjs:main Nov 21, 2024
7 of 11 checks passed
@KermanX KermanX changed the title fix: run preparser when no addons are used fix: setup preparser correctly when no addons are used Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants