perf: use Shiki shorthand #2026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
create-slidev
@slidev/parser
@slidev/cli
@slidev/client
@slidev/types
create-slidev-theme
commit: |
kermanx
commented
Jan 29, 2025
| @@ -57,8 +57,7 @@ export type ShikiSetupReturn = | |||
| & CodeOptionsThemes<BuiltinTheme> | |||
| & CodeOptionsMeta | |||
| & { | |||
| setup: (highlighter: Highlighter) => Awaitable<void> | |||
There was a problem hiding this comment.
It seems that this function is never called. And I don't know how to support it because there's no longer a Highlighter
There was a problem hiding this comment.
We can get the highlighter with:
const shiki = createSingletonShorthands<string, string>(createHighlighter)
const highlighter = await shiki.getSingletonHighlighter()But I don't mind removing it if no one uses it
kermanx
commented
Jan 30, 2025
Comment on lines
+10
to
+12
| // trigger the shiki to load the langs | ||
| shiki.codeToHast('', { lang: 'js', ...shikiOptions }), | ||
| shiki.codeToHast('', { lang: 'ts', ...shikiOptions }), |
There was a problem hiding this comment.
This is an ugly workaround 🥲
I tried passing lang and langAlias to transformerTwoslash, but it either complains "language not loaded" or doesn't transform the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the demo slides' start-up time (from running the command to printing the URLs) by almost 2s on my machine.