supporting option for slim-repeat

slimjs · Apr 2, 2017 · 0fddfe5 · 0fddfe5
1 parent fc06298
commit 0fddfe5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/Slim.js b/Slim.js
@@ -247,7 +247,7 @@ class Slim extends HTMLElement {
             type: 'R',
             target: child,
             targetAttribute: child.getAttribute('slim-repeat-as') ? child.getAttribute('slim-repeat-as') : 'data',
-            repeatAdjacent: child.hasAttribute('slim-repeat-adjacent'),
+            repeatAdjacent: child.hasAttribute('slim-repeat-adjacent') || child.localName === 'option',
             attribute: attribute.nodeName,
             properties: [ attribute.nodeValue ],
             source: child._boundParent

diff --git a/bin/Slim.min.js b/bin/Slim.min.js
diff --git a/example/tests/test-repeater.html b/example/tests/test-repeater.html
@@ -8,6 +8,9 @@
         <script>
             Slim.tag('repeat-tester',
             `
+            <select>
+                <option slim-repeat="items" value="[[data.value]]" bind>[[data.label]]</option>
+            </select>
             <ul>
                 <li slim-repeat="items" slim-repeat-as="item" click="handleItemSelect">
                     <span active="[[isActive(item)]]" bind>[[item.label]]</span>
@@ -16,6 +19,7 @@
             `,
             class extends Slim {
                 onBeforeCreated() {
+                    window.unit = this;
                     this.items = [
                         {label: 'item 1', value: 1},
                         {label: 'item 2', value: 2},