fixing serious typo in findAll

slimjs · May 29, 2017 · 1e5c115 · 1e5c115
1 parent e31f7cf
commit 1e5c115
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/Slim.js b/Slim.js
@@ -29,7 +29,7 @@ var Slim = function (_CustomElement2) {
          * Best practice to call polyfill in <head> section of the HTML
          * @example
          *      <head>
-         *          <script src="./path/to/slim/Slim.min.js></script>
+         *          <script src="./path/to/slim/Slim.min.js"></script>
          *          <script>
          *              Slim.polyfill('./path/to/web-components-polyfill.js');
          *          </script>
@@ -368,7 +368,7 @@ var Slim = function (_CustomElement2) {
     }, {
         key: 'findAll',
         value: function findAll(selector) {
-            return Slim.selectorToArr(this.rootElemnt, selector);
+            return Slim.selectorToArr(this.rootElement, selector);
         }
     }, {
         key: 'watch',

diff --git a/Slim.min.js b/Slim.min.js
diff --git a/example/stargazers/index.html b/example/stargazers/index.html
@@ -4,10 +4,8 @@
     <meta charset="UTF-8">
     <title>Stargazers Demo</title>
     <script src="https://cdnjs.cloudflare.com/ajax/libs/fetch/2.0.3/fetch.min.js"></script>
+    <script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.0.1/webcomponents-hi-ce.js"></script>
     <script src="../../src/Slim.js"></script>
-    <script>
-        Slim.polyfill('https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/0.7.24/CustomElements.min.js');
-    </script>
     <script src="stargazers-demo.js"></script>
     <script src="stargazers-item.js"></script>
 </head>

diff --git a/example/stargazers/stargazers-demo.js b/example/stargazers/stargazers-demo.js
@@ -62,8 +62,8 @@ Slim.tag('stargazers-demo',
             fetch(`https://api.github.com/repos/${this.repoName}/stargazers?page=1&per_page=100`)
                 .then(response => response.json() )
                 .then(stargazers => {
-                    this.stargazers = stargazers;
                     this.isLoading = false;
+                    this.stargazers = stargazers;
                 });
         }
 });
diff --git a/src/Slim.js b/src/Slim.js
@@ -256,7 +256,7 @@ class Slim extends HTMLElement {
 
     //noinspection JSUnusedGlobalSymbols
     findAll(selector) {
-        return Slim.selectorToArr(this.rootElemnt, selector);
+        return Slim.selectorToArr(this.rootElement, selector);
     }
 
     watch(prop, executor) {