-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: slint-lsp open to open the preview standalone
#7576
Draft
ogoffart
wants to merge
1
commit into
master
Choose a base branch
from
olivier/lsp-standalone
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| // Copyright © SixtyFPS GmbH <[email protected]> | ||
| // SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0 | ||
|
|
||
| use crate::OutgoingRequestQueue; | ||
| use core::cell::RefCell; | ||
| use core::future::Future; | ||
| use core::pin::Pin; | ||
| use core::task::Poll; | ||
| use lsp_types::notification::Notification; | ||
| use std::rc::Rc; | ||
| use std::sync::Arc; | ||
|
|
||
| pub fn open( | ||
| args: super::Cli, | ||
| path: std::path::PathBuf, | ||
| component: Option<String>, | ||
| ) -> crate::common::Result<()> { | ||
| let cli_args = args.clone(); | ||
| let lsp_thread = std::thread::Builder::new() | ||
| .name("LanguageServer".into()) | ||
| .spawn(move || { | ||
| /// Make sure we quit the event loop even if we panic | ||
| struct QuitEventLoop; | ||
| impl Drop for QuitEventLoop { | ||
| fn drop(&mut self) { | ||
| super::preview::quit_ui_event_loop(); | ||
| } | ||
| } | ||
| let quit_ui_loop = QuitEventLoop; | ||
| if let Err(e) = fake_lsp(args, path, component) { | ||
| eprintln!("{e}"); | ||
| std::process::exit(1); | ||
| } | ||
| drop(quit_ui_loop); | ||
| }) | ||
| .unwrap(); | ||
|
|
||
| super::preview::start_ui_event_loop(cli_args); | ||
| lsp_thread.join().unwrap(); | ||
| Ok(()) | ||
| } | ||
|
|
||
| fn fake_lsp( | ||
| args: super::Cli, | ||
| path: std::path::PathBuf, | ||
| component: Option<String>, | ||
| ) -> crate::common::Result<()> { | ||
| let request_queue = OutgoingRequestQueue::default(); | ||
| let (preview_to_lsp_sender, preview_to_lsp_receiver) = | ||
| crossbeam_channel::unbounded::<crate::common::PreviewToLspMessage>(); | ||
| let (preview_to_client_sender, preview_to_client_reciever) = | ||
| crossbeam_channel::unbounded::<lsp_server::Message>(); | ||
| let server_notifier = crate::ServerNotifier { | ||
| sender: preview_to_client_sender, | ||
| queue: request_queue.clone(), | ||
| use_external_preview: Default::default(), | ||
| preview_to_lsp_sender, | ||
| }; | ||
|
|
||
| super::preview::set_server_notifier(server_notifier.clone()); | ||
|
|
||
| let compiler_config = args.into_compiler_config(|m| super::preview::lsp_to_preview_message(m)); | ||
|
|
||
| let init_param = lsp_types::InitializeParams { | ||
| capabilities: lsp_types::ClientCapabilities { | ||
| workspace: Some(lsp_types::WorkspaceClientCapabilities { | ||
| did_change_watched_files: Some( | ||
| lsp_types::DidChangeWatchedFilesClientCapabilities { | ||
| dynamic_registration: Some(true), | ||
| ..Default::default() | ||
| }, | ||
| ), | ||
| ..Default::default() | ||
| }), | ||
| ..Default::default() | ||
| }, | ||
| ..Default::default() | ||
| }; | ||
|
|
||
| let ctx = Rc::new(crate::Context { | ||
| document_cache: RefCell::new(crate::common::DocumentCache::new(compiler_config)), | ||
| preview_config: RefCell::new(Default::default()), | ||
| server_notifier, | ||
| init_param, | ||
| #[cfg(any(feature = "preview-external", feature = "preview-engine"))] | ||
| to_show: Default::default(), | ||
| open_urls: Default::default(), | ||
| }); | ||
|
|
||
| let ctx_ = ctx.clone(); | ||
| let contents = std::fs::read_to_string(&path)?; | ||
| let absolute_path = std::fs::canonicalize(path)?; | ||
| let future = Box::pin(async move { | ||
| let url = lsp_types::Url::from_file_path(&absolute_path).unwrap(); | ||
| crate::open_document( | ||
| &ctx_, | ||
| contents, | ||
| url.clone(), | ||
| None, | ||
| &mut ctx_.document_cache.borrow_mut(), | ||
| ) | ||
| .await?; | ||
| let mut args = vec![serde_json::to_value(url).unwrap()]; | ||
| if let Some(component) = component { | ||
| args.push(serde_json::Value::String(component)); | ||
| } | ||
| crate::language::show_preview_command(&args, &ctx_).map_err(|e| e.message)?; | ||
| Ok(()) | ||
| }); | ||
|
|
||
| // We are waiting in this loop for two kind of futures: | ||
| // - The compiler future should always be ready immediately because we do not set a callback to load files | ||
| // - the future from `send_request` are blocked waiting for a response from the client (us) and we make sure | ||
| // that they are available immediately. | ||
| struct DummyWaker; | ||
| impl std::task::Wake for DummyWaker { | ||
| fn wake(self: Arc<Self>) {} | ||
| } | ||
| let waker = Arc::new(DummyWaker).into(); | ||
| let mut futures = Vec::<Pin<Box<dyn Future<Output = crate::common::Result<()>>>>>::new(); | ||
| futures.push(future); | ||
|
|
||
| loop { | ||
| let mut result = Ok(()); | ||
| futures.retain_mut(|f| { | ||
| if result.is_err() { | ||
| return true; | ||
| } | ||
| match f.as_mut().poll(&mut std::task::Context::from_waker(&waker)) { | ||
| Poll::Ready(x) => { | ||
| result = x; | ||
| false | ||
| } | ||
| Poll::Pending => true, | ||
| } | ||
| }); | ||
| result?; | ||
| crossbeam_channel::select! { | ||
| recv(preview_to_client_reciever) -> msg => { | ||
| match msg? { | ||
| lsp_server::Message::Notification(n) if n.method == lsp_types::notification::PublishDiagnostics::METHOD => (), | ||
| msg => eprintln!("Got client message from preview: {msg:?}") | ||
| }; | ||
| }, | ||
| recv(preview_to_lsp_receiver) -> msg => { | ||
| use crate::common::PreviewToLspMessage as M; | ||
| match msg? { | ||
| M::Status { .. } => (), | ||
| M::Diagnostics { uri, version: _, diagnostics } => { | ||
| // print to stdout, what else can we do? | ||
| for d in diagnostics { | ||
| let severity = match d.severity { | ||
| Some(lsp_types::DiagnosticSeverity::ERROR) => "Error: ", | ||
| Some(lsp_types::DiagnosticSeverity::WARNING) => "Warning: ", | ||
| Some(lsp_types::DiagnosticSeverity::INFORMATION) => "Info: ", | ||
| Some(lsp_types::DiagnosticSeverity::HINT) => "Hint: ", | ||
| _ => "", | ||
| }; | ||
| println!("{uri:?}:{} {severity}{}", d.range.start.line, d.message); | ||
| } | ||
| }, | ||
| M::ShowDocument { .. } => (), | ||
| M::PreviewTypeChanged { .. } => unreachable!("can't change type to external"), | ||
| M::RequestState { unused: _ } => { | ||
| crate::language::request_state(&ctx); | ||
| }, | ||
| M::SendWorkspaceEdit { label:_, edit } => { | ||
| let edits = crate::common::text_edit::apply_workspace_edit(&ctx.document_cache.borrow(), &edit)?; | ||
| for e in edits { | ||
| std::fs::write(e.url.to_file_path().unwrap(), &e.contents)?; | ||
| // FIXME: fs watcher should take care of this automatically | ||
| let ctx = ctx.clone(); | ||
| futures.push(Box::pin(async move { | ||
| crate::language::reload_document(&ctx, e.contents, e.url, None, &mut ctx.document_cache.borrow_mut()).await | ||
| })); | ||
| } | ||
|
|
||
| }, | ||
| M::SendShowMessage { message } => { | ||
| eprint!("{}", message.message); | ||
| }, | ||
| }; | ||
| }, | ||
| }; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a fake language server?
It feels easier to extend the live-preview to request the files it did not find than to do an entire extra parsing run to find those... And that is the only functionality we really need from the LS at this point in time.