Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar, Changing the Activity type to Listening and Secondary Button support #247

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Progress bar, Changing the Activity type to Listening and Secondary Button support #247

wants to merge 15 commits into from

Conversation

fumiichan
Copy link
Contributor

@fumiichan fumiichan commented Sep 17, 2024 •
edited
Loading

This PR contains the following changes:

  • Use of DiscordRichPresence library changed to directly use master branch
  • Removed "Show Remaining time" option in favour of Progress Bar display
  • Changed Activity Type to "Listening" (Closes Add "Listening to" as a option instead of default "Playing" #242)
  • Adds support for a second button (Closes Second custom button #235)
  • Updated RestSharp to non-vulnerable version
  • Do not display progress bar when duration value is -1.
  • Added support to update rich presence when album art is ready

For testers, here's a prebuilt with up-to-date changes:
https://github.com/doujincafe/DiscordBee/releases/tag/v3.1.0-experimental3.1-1

Preview:
image
image

@fumiichan fumiichan changed the title Progress bar and Change of Activity Type Progress bar, Listening to Activity Type and Secondary Button support Sep 18, 2024
@fumiichan fumiichan changed the title Progress bar, Listening to Activity Type and Secondary Button support Progress bar, Changing the Activity type to Listening and Secondary Button support Sep 18, 2024
@sll552 sll552 self-assigned this Oct 13, 2024
@sll552 sll552 added enhancement New feature or request bugfix Fixes a bug labels Oct 13, 2024
@Chinhsss
Copy link

image
image
Placeholder in album cover seem like also appear in progress bar?

@fumiichan
Copy link
Contributor Author

It's Discord's issue or by design.

@Chinhsss
Copy link

It's Discord's issue or by design.
Original DiscordBee doesn't have that issue, so i think it might be something with the progress bar

@fumiichan
Copy link
Contributor Author

That happens only when Activity type is configured to Listening.

Other clients for example also does this:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sll552 sll552

Labels
bugfix Fixes a bug enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Listening to" as a option instead of default "Playing" Second custom button
4 participants
@fumiichan @Chinhsss @sll552 @RegorForgot