Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first attempt at providing an XMLSchema for dfg-viewer.de namespace #196

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented Jan 26, 2022

There has been an informal definition of an XML namespace http://dfg-viewer.de in various parts of Kitodo and DFG Viewer for some time. Without a formalization, there is no validation, and re-implementation is difficult. I tried to fill the gap here, but …

  1. not sure if this is the right place. Perhaps better use a new repo?
  2. not sure about various details (see fixmes and references in the XSD). I had to rework from the implementations and example XMLs I could find. Perhaps I missed or misinterpreted some of them?
  3. not sure whether a single XSD for the 4 different roots is adequate, and how we can validate that the right kind of root gets used in the right context – i.e.
    • dv:rights only in mets:amdSec/mets:rightsMD,
    • dv:links only in mets:amdSec/mets:digiprovMD,
    • ?? only in mets:amdSec/mets:techMD,
    • dv:page only in SRU responses).

I have added the XSD under Resources/Public/Xsd/dfg-viewer.xsd – which could be used as a schemaLocation for dv XMLs in the future. I also added some example XMLs as test cases, which should probably go somewhere else.

@sebastian-meyer @Erikmitk

@bertsky
Copy link
Member Author

bertsky commented Jan 26, 2022

We should probably also formalize the METS and MODS Anwendungsprofile, including the Strukturdatenset BTW.

@bertsky
Copy link
Member Author

bertsky commented Jan 26, 2022

One more thing: I noticed some obvious inconsistencies in the dv:page documentation part of the SRU/ALTO Anwendungsprofil:

  • there is a @url on the top-level dv:page in the example, but not such entry in the documentation
  • the dv:page/dv:fulltexthit is documented as not repeatable, but in the implementation it clearly is
  • the dv:page/dv:fulltexthit/dv:page is documented as not repeatable, but in the example, it clearly is

@sebastian-meyer sebastian-meyer self-requested a review January 26, 2022 13:48
@sebastian-meyer sebastian-meyer removed their request for review October 17, 2022 08:46
@beatrycze-volk beatrycze-volk added ✔️ feature A new feature or enhancement. 📄 design labels Oct 19, 2023
@beatrycze-volk beatrycze-volk marked this pull request as draft October 24, 2023 11:14
@MarcMoschSLUB
Copy link

Thanks @bertsky. We will most likely pick up this issue with DFG-Viewer 3D second phase. It can serve as a base for the METS validator (AP 1-3 at https://intranet.slub-dresden.de/pages/viewpage.action?pageId=488903266).

Comment on lines +81 to +83
<xs:element name="license" minOccurs="0" default="reserved">
<xs:simpleType>
<xs:restriction base="xs:string">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do we have to include other values (like CNE or NoC) here, too?

Cf. Europeana license codes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ feature A new feature or enhancement. 📄 design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants