Merge pull request #38 from slub/33-one-part-names

Test one part authors
slub · Nov 28, 2024 · cd8f048 · cd8f048
2 parents 2558121 + 16242a8
commit cd8f048
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 12 deletions.
diff --git a/Classes/Processing/BibEntryProcessor.php b/Classes/Processing/BibEntryProcessor.php
@@ -16,8 +16,9 @@
 use Illuminate\Support\Stringable;
 use Illuminate\Support\Str;
 use Slub\LisztCommon\Common\Collection;
+use Slub\LisztCommon\Processing\IndexProcessor;
 
-class BibEntryProcessor
+class BibEntryProcessor extends IndexProcessor
 {
 
     public static function process(
@@ -32,28 +33,28 @@ public static function process(
             $bibliographyItem['localizedCitations'][$locale] = $localizedCitation->get($key)['citation'];
         }
         $bibliographyItem['tei'] = $teiDataSets->get($key);
-        $bibliographyItem['tx_lisztcommon_header'] = self::buildListingField($bibliographyItem, BibEntryConfig::getAuthorHeader());
-        if ($bibliographyItem['tx_lisztcommon_header'] == '') {
-            $bibliographyItem['tx_lisztcommon_header'] = self::buildListingField($bibliographyItem, BibEntryConfig::getEditorHeader());
+        $bibliographyItem[self::HEADER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getAuthorHeader());
+        if ($bibliographyItem[self::HEADER_FIELD] == '') {
+            $bibliographyItem[self::HEADER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getEditorHeader());
         }
-        $bibliographyItem['tx_lisztcommon_body'] = self::buildListingField($bibliographyItem, BibEntryConfig::getBody());
-        switch($bibliographyItem['itemType']) {
+        $bibliographyItem[self::BODY_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getBody());
+        switch($bibliographyItem[self::TYPE_FIELD]) {
             case 'book':
-                $bibliographyItem['tx_lisztcommon_footer'] = self::buildListingField($bibliographyItem, BibEntryConfig::getBookFooter());
+                $bibliographyItem[self::FOOTER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getBookFooter());
                 break;
             case 'bookSection':
-                $bibliographyItem['tx_lisztcommon_footer'] = self::buildListingField($bibliographyItem, BibEntryConfig::getBookSectionFooter());
+                $bibliographyItem[self::FOOTER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getBookSectionFooter());
                 break;
             case 'journalArticle':
-                $bibliographyItem['tx_lisztcommon_footer'] = self::buildListingField($bibliographyItem, BibEntryConfig::getArticleFooter());
+                $bibliographyItem[self::FOOTER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getArticleFooter());
                 break;
             case 'thesis':
-                $bibliographyItem['tx_lisztcommon_footer'] = self::buildListingField($bibliographyItem, BibEntryConfig::getThesisFooter());
+                $bibliographyItem[self::FOOTER_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::getThesisFooter());
                 break;
         }
 
-        $bibliographyItem['tx_lisztcommon_searchable'] = self::buildListingField($bibliographyItem, BibEntryConfig::SEARCHABLE_FIELDS);
-        $bibliographyItem['tx_lisztcommon_boosted'] = self::buildListingField($bibliographyItem, BibEntryConfig::BOOSTED_FIELDS);
+        $bibliographyItem[self::SEARCHABLE_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::SEARCHABLE_FIELDS);
+        $bibliographyItem[self::BOOSTED_FIELD] = self::buildListingField($bibliographyItem, BibEntryConfig::BOOSTED_FIELDS);
 
         return $bibliographyItem;
     }

diff --git a/Tests/Unit/Processing/BibEntryProcessorTest.php b/Tests/Unit/Processing/BibEntryProcessorTest.php
@@ -20,6 +20,7 @@ final class BibEntryProcessorTest extends UnitTestCase
     private ?BibEntryProcessor $subject = null;
     private array $exampleBookArray = [];
     private array $exampleBookWithoutAuthorArray = [];
+    private array $exampleBookWithAnonymousAuthorArray = [];
     private array $exampleBookSectionArray = [];
     private array $exampleArticleArray = [];
 
@@ -37,6 +38,7 @@ final class BibEntryProcessorTest extends UnitTestCase
 
     private string $exampleBook = '';
     private string $exampleBookWithoutAuthor = '';
+    private string $exampleBookWithAnonymousAuthor = '';
     private string $exampleArticle = '';
     private string $exampleBookSection = '';
 
@@ -80,6 +82,24 @@ protected function setUp(): void
             }
             JSON;
 
+        $this->exampleBookWithAnonymousAuthor =
+            <<<JSON
+            {
+                "key": "key",
+                "itemType": "book",
+                "title": "$this->title",
+                "creators": [
+                    {
+                        "creatorType": "author",
+                        "firstName": "",
+                        "lastName": "$this->authorLastName"
+                    }
+                ],
+                "place": "$this->place",
+                "date": "$this->date"
+            }
+            JSON;
+
         $this->exampleArticle =
             <<<JSON
             {
@@ -129,6 +149,7 @@ protected function setUp(): void
         $this->subject = GeneralUtility::makeInstance(BibEntryProcessor::class);
         $this->exampleBookArray = json_decode($this->exampleBook, true);
         $this->exampleBookWithoutAuthorArray = json_decode($this->exampleBookWithoutAuthor, true);
+        $this->exampleBookWithAnonymousAuthorArray = json_decode($this->exampleBookWithAnonymousAuthor, true);
         $this->exampleArticleArray = json_decode($this->exampleArticle, true);
         $this->exampleBookSectionArray = json_decode($this->exampleBookSection, true);
     }
@@ -147,14 +168,17 @@ public function headerIsProcessedCorrectly(): void
         $bookSection = $this->subject->process($this->exampleBookSectionArray, new Collection(), new Collection());
         $article = $this->subject->process($this->exampleArticleArray, new Collection(), new Collection());
         $bookWithoutAuthor = $this->subject->process($this->exampleBookWithoutAuthorArray, new Collection(), new Collection());
+        $bookWithAnonymousAuthor = $this->subject->process($this->exampleBookWithAnonymousAuthorArray, new Collection(), new Collection());
 
         $expected = Str::of($this->authorFirstName . ' ' . $this->authorLastName);
         $expectedWithoutAuthor = Str::of($this->editorFirstName . ' ' . $this->editorLastName . ' (Hg.)');
+        $expectedWithAnonymousAuthor = Str::of($this->authorLastName);
 
         self::assertEquals($book['tx_lisztcommon_header'], $expected);
         self::assertEquals($bookSection['tx_lisztcommon_header'], $expected);
         self::assertEquals($article['tx_lisztcommon_header'], $expected);
         self::assertEquals($bookWithoutAuthor['tx_lisztcommon_header'], $expectedWithoutAuthor);
+        self::assertEquals($bookWithAnonymousAuthor['tx_lisztcommon_header'], $expectedWithAnonymousAuthor);
     }
 
     /**