Merge pull request #8 from beatrycze-volk/implement-subject

Implement functions in Subject class and its child element classes
slub · Apr 12, 2024 · 87ae6eb · 87ae6eb
2 parents 01034c9 + e9a5fcc
commit 87ae6eb
Show file tree

Hide file tree

Showing 10 changed files with 429 additions and 263 deletions.
diff --git a/src/Mods/Element/Common/BaseElement.php b/src/Mods/Element/Common/BaseElement.php
@@ -41,7 +41,7 @@ public function __construct(\SimpleXMLElement $xml)
     }
 
     /**
-     * Get the text value of element
+     * Get the text value of element.
      *
      * @access public
      *
@@ -53,7 +53,13 @@ public function getValue(): string
     }
 
     /**
-     * Get the string value of attribute
+     * Get the string value of attribute.
+     *
+     * @access public
+     *
+     * @param string $attribute name
+     *
+     * @return string
      */
     protected function getStringAttribute($attribute): string
     {
@@ -66,4 +72,25 @@ protected function getStringAttribute($attribute): string
         }
         return '';
     }
+
+    /**
+     * Get the int value of attribute.
+     *
+     * @access public
+     *
+     * @param string $attribute name
+     *
+     * @return int
+     */
+    protected function getIntAttribute($attribute): int
+    {
+        if ($this->xml->attributes() != null) {
+            $value = $this->xml->attributes()->$attribute;
+
+            if (!empty($value)) {
+                return (int) $value;
+            }
+        }
+        return 0;
+    }
 }
diff --git a/src/Mods/Element/Part.php b/src/Mods/Element/Part.php
@@ -90,12 +90,7 @@ public function getType(): string
      */
     public function getOrder(): int
     {
-        $value = $this->xml->attributes()->order;
-
-        if (!empty($value)) {
-            return (int) $value;
-        }
-        return 0;
+        return $this->getIntAttribute('order');
     }
 
     /**

diff --git a/src/Mods/Element/Specific/Part/Detail.php b/src/Mods/Element/Specific/Part/Detail.php
@@ -76,12 +76,7 @@ public function getType(): string
      */
     public function getLevel(): int
     {
-        $value = $this->xml->attributes()->level;
-
-        if (!empty($value)) {
-            return (int) $value;
-        }
-        return 0;
+        return $this->getIntAttribute('level');
     }
 
     /**