-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for musical sources #53
Support for musical sources #53
Conversation
c4e2d9f
to
c3f73d9
Compare
…-webwork/slub_digitalcollections into verovio-neu-measure-navigation
<a href="#" id="tx_dlf_scoredownload" class="download-document"> | ||
<f:translate key="scoredownload"/> (PDF) | ||
</a> | ||
</li> | ||
</f:then> | ||
</f:if> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: how this functionality can be tested? Could you add some description and maybe some screenshot?
Please rebase this branch |
# Conflicts: # Resources/Private/Partials/KitodoPageView.html # Resources/Private/Plugins/Kitodo/Templates/Toolbox/Main.html # Resources/Public/Css/Digitalcollections.css
Co-authored-by: Sebastian Meyer <[email protected]>
This is fine, now! I'll check it out for final testing as soon as the other branches are finished! |
@beatrycze-volk @MarcMoschSLUB Who is responsible for merging finally reviewing and merging this? From my point of view this is ready to be merged. The corresponding PR kitodo/kitodo-presentation#1281 has already been merged and will be part of the upcoming Kitodo.Presentation 5.1/6.0 release. The PR slub/dfg-viewer#230 is also ready for merging. |
@MarcMoschSLUB makes merges in this repository. If you say that it is now ready, I remove my change request as it looks it still somewhere in the history of PR :) |
No description provided.