Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for musical sources #53

Merged

Conversation

haogatyp
Copy link
Contributor

No description provided.

@haogatyp haogatyp force-pushed the verovio-neu-measure-navigation branch from c4e2d9f to c3f73d9 Compare September 5, 2023 08:22
Resources/Private/Partials/KitodoPageView.html Outdated Show resolved Hide resolved
<a href="#" id="tx_dlf_scoredownload" class="download-document">
<f:translate key="scoredownload"/> (PDF)
</a>
</li>
</f:then>
</f:if>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: how this functionality can be tested? Could you add some description and maybe some screenshot?

@beatrycze-volk
Copy link
Contributor

Please rebase this branch

# Conflicts:
#	Resources/Private/Partials/KitodoPageView.html
#	Resources/Private/Plugins/Kitodo/Templates/Toolbox/Main.html
#	Resources/Public/Css/Digitalcollections.css
@sebastian-meyer sebastian-meyer changed the title Verovio neu measure navigation Support for musical sources Jul 8, 2024
@sebastian-meyer
Copy link
Member

This is fine, now! I'll check it out for final testing as soon as the other branches are finished!

@sebastian-meyer sebastian-meyer assigned haogatyp and unassigned haogatyp Jul 16, 2024
@sebastian-meyer sebastian-meyer added the enhancement New feature or request label Jul 16, 2024
@sebastian-meyer
Copy link
Member

@beatrycze-volk @MarcMoschSLUB Who is responsible for merging finally reviewing and merging this? From my point of view this is ready to be merged. The corresponding PR kitodo/kitodo-presentation#1281 has already been merged and will be part of the upcoming Kitodo.Presentation 5.1/6.0 release. The PR slub/dfg-viewer#230 is also ready for merging.

@beatrycze-volk
Copy link
Contributor

@MarcMoschSLUB makes merges in this repository.

If you say that it is now ready, I remove my change request as it looks it still somewhere in the history of PR :)

@MarcMoschSLUB MarcMoschSLUB merged commit 05313de into slub:master Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants