Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ConfigMapping validateUnknown to enable / disable validation of unknown configurations in the mapping path #1238

Closed
wants to merge 1 commit into from

Conversation

radcortez
Copy link
Member

No description provided.

@dmlloyd
Copy link
Contributor

dmlloyd commented Oct 7, 2024

What if two mappings have conflicting settings? I don't think this is the right place for this. Also we'll have to support if forever if it's on the public api like this. Even if we rewrite, which we may end up doing.

@radcortez
Copy link
Member Author

It is no different from the builder API.

The issue is that we have to disable the validation in Quarkus because the configuration may be split between build time and runtime. However, it is only disabled for the quarkus namespace. Some Quarkiverse extensions are now moving to mappings and using a different namespace. They must provide a config builder to disable the validation to their namespace, which is annoying, so I thought it would be easier to allow it in the annotation.

@dmlloyd
Copy link
Contributor

dmlloyd commented Oct 7, 2024

The config mapping interface does not correspond to a namespace (i.e. two mappings could overlap). Another difference is that this interface is supported as a Quarkus API whereas the programmatic API is not.

@radcortez radcortez closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants