Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better config properties #1088

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Nov 26, 2024

@Ladicek Ladicek added this to the 6.7.0 milestone Nov 26, 2024
The old config properties, specified by MP Fault Tolerance, are still
supported, but the new ones are preferred. The transformation is:

- `<classname>/<methodname>/<annotation>/<member>` moves to
  `smallrye.faulttolerance."<classname>/<methodname>".<annotation>.<member>`
- `<classname>/<annotation>/<member>` moves to
  `smallrye.faulttolerance."<classname>".<annotation>.<member>`
- `<annotation>/<member>` moves to
  `smallrye.faulttolerance.global.<annotation>.<member>`

All the `<annotation>` and `<member>` parts are changed from camel case
(`BeforeRetry`, `methodName`) to kebab case (`before-retry`, `method-name`).
Two annotation members are special cased to improve consistency:

- `Retry/durationUnit` moves to `retry.max-duration-unit`
- `Retry/jitterDelayUnit` moves to `retry.jitter-unit`

Further:

- `MP_Fault_Tolerance_NonFallback_Enabled` moves to `smallrye.faulttolerance.enabled`
- `MP_Fault_Tolerance_Metrics_Enabled` moves to `smallrye.faulttolerance.metrics.enabled`
@Ladicek Ladicek merged commit ee81b70 into smallrye:main Nov 27, 2024
13 checks passed
@Ladicek Ladicek deleted the better-config-properties branch November 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant