Fixing some bugs regarding transformation of annotation 'java.lang.Deprecated' to graphQL's 'Deprecated'. directive. #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
requested changes
Aug 31, 2023
common/schema-model/src/main/java/io/smallrye/graphql/schema/model/EnumValue.java
Outdated
Show resolved
Hide resolved
mskacelik
force-pushed
the
deprecatedhelper-small-fix
branch
from
2439d11 to
538d05f
Compare
jmartisk
approved these changes
Aug 31, 2023
…tions (high level fields), enum values, output type fields. Also fixed that while using generate-schema goal, there is no NPE. + minor refactoring of the code.
mskacelik
force-pushed
the
deprecatedhelper-small-fix
branch
from
538d05f to
18eadc1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:#1896
/cc @jmartisk
Changes:
Changes:
Optional<DirectiveInstance>type instead of the raw type. This change eliminates situations where the method could returnnullor a list, as was the case withDeprecatedDirectivesHelper. Since thejava.lang.Deprecatedis non repeatable annotation.java.lang.Deprecatedduring schema generation via thesmallrye-graphql-maven-plugingoal:generating-schema. The issue stemmed from the fact thatGenerateSchemaMojodid not scan thesmallrye-graphql-api, where the GraphQL Deprecated annotation was defined.java.lang.Deprecatedfrom operations (high-level fields), enum values, and field definitions of an output type. This addition complements the existing implementation for attribute definitions and input type field definitions.tests: quarkusio/quarkus@204c115