Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webjars with mvnpm #1907

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Replace webjars with mvnpm #1907

merged 1 commit into from
Sep 6, 2023

Conversation

phillip-kruger
Copy link
Member

No description provided.

Signed-off-by: Phillip Kruger <[email protected]>
@jmartisk
Copy link
Member

jmartisk commented Sep 6, 2023

What exactly is the benefit from this? I'm worried about adding more problematic work to the productization team because they will have to productize these new libraries for RHBQ

@phillip-kruger
Copy link
Member Author

Do they currently do it for the web jars? We have much more control with mvnpm. It's smaller, and it auto update. It's replacing all web jars in Quarkus. So the new dev ui is using it, swagger ui now use it. All that is left is graphql

@jmartisk
Copy link
Member

jmartisk commented Sep 6, 2023

Ah, ok if everything else is using it, then we probably want GraphQL too. Just a question, what do you mean by "auto update"? How does that work? I hope you don't mean that it will download a different artifact without us changing the version in the pom....

@phillip-kruger
Copy link
Member Author

No, but we should get dependabot alerts when a new version is released. So the sync between npm and maven central is automatically done. With web jars someone have to go to the website and do the sync.

@jmartisk jmartisk merged commit 3408694 into smallrye:main Sep 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants