Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement federation batch resolving #1908

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

robp94
Copy link
Contributor

@robp94 robp94 commented Sep 7, 2023

@t1 @jmartisk @phillip-kruger I transferred our implementation of batch resolving. Refactorings or simpler versions are welcome. I shortly add some tests in quarkus.

@robp94
Copy link
Contributor Author

robp94 commented Sep 7, 2023

#1903

@jmartisk
Copy link
Member

jmartisk commented Sep 13, 2023

Very nice, thanks! Given that this adds a new config property, I think it warrants a minor version bump. I'll bump the version to 2.5.0-SNAPSHOT after this. I'll also create my own Quarkus branch named smallrye-graphql-2.5.0 where I will cherry-pick the contents of your Quarkus PR (quarkusio/quarkus#35802) and submit it for Quarkus main after we actually release 2.5.0. This is the usual way how we handle cross-project fixes here.
Awesome work, thanks!

@jmartisk jmartisk merged commit 771e151 into smallrye:main Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants