Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'provided' scope from some client dependencies #2208

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jmartisk
Copy link
Member

Kinda a continuation of #2196
The idea is that a standalone Java SE app should only need to declare the smallrye-graphql-client-implementation-vertx dependency and be able to fully run with just that. This fixes the usage of dynamic client this way

@jmartisk jmartisk merged commit 57220e0 into smallrye:main Oct 11, 2024
5 checks passed
@jmartisk jmartisk deleted the standalone-dependencies branch October 11, 2024 10:46
@t1
Copy link
Collaborator

t1 commented Oct 11, 2024

I can understand the intention, but then we have to exclude these dependencies when the client runs, e.g., within an application runtime that already brings these dependencies OOTB.

Maybe we should add a module smallrye-graphql-client-standalone or something?

@jmartisk
Copy link
Member Author

jmartisk commented Oct 11, 2024

I can understand the intention, but then we have to exclude these dependencies when the client runs, e.g., within an application runtime that already brings these dependencies OOTB.

Please elaborate on which case you're talking about - for example, when developing for WildFly and a WAR packaging, you would declare just a provided dependency on smallrye-graphql-client-api, so you don't get any of this included in the WAR.. (and even if you depend on the whole smallrye-graphql-client-implementation-vertx, then as long as it's provided, it doesn't get into the WAR)

With Quarkus, these are already added by Quarkus anyway, and it wouldn't work without them.

@jmartisk
Copy link
Member Author

With WF feature pack 2.5.0, you should just be able to just compile with a provided dependency and you need exactly nothing else, not even declare a META-INF/MANIFEST.MF dependency on any wildfly modules, the modules should be added automatically, based on detecting a @GraphQLClientApi annotation in the deployment (we might need to figure out how to do it for dynamic clients too)

@t1
Copy link
Collaborator

t1 commented Oct 12, 2024

You're right. Sometimes I'm astonishingly stupid 😳 Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants