Merge pull request #641 from Channyboy/micrometer-mpm51-fixes

Additional fixes for 5.1.0
smallrye · Sep 21, 2023 · 68dc254 · 68dc254
2 parents 5dedbc2 + 0c3e73c
commit 68dc254
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/implementation/src/main/java/io/smallrye/metrics/exporters/PrometheusMetricsExporter.java b/implementation/src/main/java/io/smallrye/metrics/exporters/PrometheusMetricsExporter.java
@@ -190,6 +190,7 @@ private void resolveMeterSuffixes(Set<String> set, Type inputType) {
                 set.add("_count");
                 set.add("_sum");
                 set.add("_max");
+                set.add("_bucket");
                 break;
             default:
                 if (LOGGER.isLoggable(Level.FINEST)) {

diff --git a/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMaxConfiguration.java b/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMaxConfiguration.java
@@ -53,7 +53,10 @@ public static Collection<HistogramBucketMaxConfiguration> parse(String input) {
             }
 
             // LIFO - right most configuration takes precedence
-            metricBucketMinMax.addFirst(metricBucketConfiguration);
+            if (metricBucketConfiguration != null) {
+                metricBucketMinMax.addFirst(metricBucketConfiguration);
+            }
+
         }
         return metricBucketMinMax;
 

diff --git a/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMinConfiguration.java b/...ation/src/main/java/io/smallrye/metrics/setup/config/HistogramBucketMinConfiguration.java
@@ -53,7 +53,10 @@ public static Collection<HistogramBucketMinConfiguration> parse(String input) {
             }
 
             // LIFO - right most configuration takes precedence
-            metricBucketMinMax.addFirst(metricBucketConfiguration);
+            if (metricBucketConfiguration != null) {
+                metricBucketMinMax.addFirst(metricBucketConfiguration);
+            }
+
         }
         return metricBucketMinMax;
 

diff --git a/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMaxConfiguration.java b/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMaxConfiguration.java
@@ -34,7 +34,7 @@ public static Collection<TimerBucketMaxConfiguration> parse(String input) {
             String metricName = keyValueSplit[0];
 
             TimerBucketMaxConfiguration sloMinConfiguration = null;
-            Duration dur;
+            Duration dur = null;
             // metricGroup=<blank> == invalid
             if (keyValueSplit.length == 2) {
 
@@ -69,10 +69,13 @@ public static Collection<TimerBucketMaxConfiguration> parse(String input) {
                 continue;
             }
 
-            sloMinConfiguration = new TimerBucketMaxConfiguration(metricName, dur);
+            if (dur != null) {
+                sloMinConfiguration = new TimerBucketMaxConfiguration(metricName, dur);
+
+                // LIFO - right most configuration takes precedence
+                sloMinConfigCollection.addFirst(sloMinConfiguration);
+            }
 
-            // LIFO - right most configuration takes precedence
-            sloMinConfigCollection.addFirst(sloMinConfiguration);
         }
         return sloMinConfigCollection;
 

diff --git a/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMinConfiguration.java b/...mentation/src/main/java/io/smallrye/metrics/setup/config/TimerBucketMinConfiguration.java
@@ -34,7 +34,7 @@ public static Collection<TimerBucketMinConfiguration> parse(String input) {
             String metricName = keyValueSplit[0];
 
             TimerBucketMinConfiguration sloMinConfiguration = null;
-            Duration dur;
+            Duration dur = null;
             // metricGroup=<blank> == invalid
             if (keyValueSplit.length == 2) {
 
@@ -69,10 +69,13 @@ public static Collection<TimerBucketMinConfiguration> parse(String input) {
                 continue;
             }
 
-            sloMinConfiguration = new TimerBucketMinConfiguration(metricName, dur);
+            if (dur != null) {
+                sloMinConfiguration = new TimerBucketMinConfiguration(metricName, dur);
+
+                // LIFO - right most configuration takes precedence
+                sloMinConfigCollection.addFirst(sloMinConfiguration);
+            }
 
-            // LIFO - right most configuration takes precedence
-            sloMinConfigCollection.addFirst(sloMinConfiguration);
         }
         return sloMinConfigCollection;