Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue about empty consul instance host #959

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

aureamunoz
Copy link
Collaborator

@aureamunoz aureamunoz commented Oct 16, 2024

No description provided.

@aureamunoz aureamunoz changed the title Add test about getting the node address when no address is provided f… Fix issue about empty consul instance host Oct 16, 2024
@aureamunoz aureamunoz marked this pull request as ready for review October 16, 2024 14:41
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document that choice and explain that it's not our choice but the documented behavior that Consul expects

@cescoffier cescoffier merged commit 59540c9 into smallrye:main Oct 17, 2024
8 checks passed
@aureamunoz aureamunoz added this to the 2.7.1 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants