-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACME (RFC 8555) § 8.2 Challenge Retries #242
base: master
Are you sure you want to change the base?
Commits on Apr 30, 2020
-
These are visual studio code's workspace configuration files.
Configuration menu - View commit details
-
Copy full SHA for 6fdbd85 - Browse repository at this point
Copy the full SHA 6fdbd85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40d7c42 - Browse repository at this point
Copy the full SHA 40d7c42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66b2c4b - Browse repository at this point
Copy the full SHA 66b2c4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9779d0 - Browse repository at this point
Copy the full SHA f9779d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d43567 - Browse repository at this point
Copy the full SHA 8d43567View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb558d - Browse repository at this point
Copy the full SHA 8fb558dView commit details -
handler_test: Add BackoffChallenge
The mock acme authority needs to in order to conform to the updated acme authority interface.
Configuration menu - View commit details
-
Copy full SHA for f56c449 - Browse repository at this point
Copy the full SHA f56c449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e6a020 - Browse repository at this point
Copy the full SHA 5e6a020View commit details
Commits on May 6, 2020
-
acme: Retry challenge validation attempts
Section 8.2 of RFC 8555 explains how retries apply to the validation process. However, much is left up to the implementer. Add retries every 12 seconds for 2 minutes after a client requests a validation. The challenge status remains "processing" indefinitely until a distinct conclusion is reached. This allows a client to continually re-request a validation by sending a post-get to the challenge resource until the process fails or succeeds. Challenges in the processing state include information about why a validation did not complete in the error field. The server also includes a Retry-After header to help clients and servers coordinate. Retries are inherently stateful because they're part of the public API. When running step-ca in a highly available setup with replicas, care must be taken to maintain a persistent identifier for each instance "slot". In kubernetes, this implies a *stateful set*.
Configuration menu - View commit details
-
Copy full SHA for 9af4dd3 - Browse repository at this point
Copy the full SHA 9af4dd3View commit details
Commits on May 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bdadea8 - Browse repository at this point
Copy the full SHA bdadea8View commit details
Commits on May 12, 2020
-
provisioner/acme: Add TODO for retry restarts
The comment in acme/authority directs users to this file so put a TODO in for posterity.
Configuration menu - View commit details
-
Copy full SHA for 9518ba4 - Browse repository at this point
Copy the full SHA 9518ba4View commit details -
vscode: Ignore vscode binaries
It might make sense to check in the vscode workspace file if we can make everything relative to the project directory.
Configuration menu - View commit details
-
Copy full SHA for 8326632 - Browse repository at this point
Copy the full SHA 8326632View commit details -
Stop execution when the error happens. This was previously a typo.
Configuration menu - View commit details
-
Copy full SHA for 2d0a00c - Browse repository at this point
Copy the full SHA 2d0a00cView commit details -
acme/authority: Polymorph the challenge type
Prior to validation, we must wrap the base challenge in the correct concrete challenge type so that we dispatch the correct validation method.
Configuration menu - View commit details
-
Copy full SHA for a857c45 - Browse repository at this point
Copy the full SHA a857c45View commit details -
acme/challenge: Copy retry information on clone
When cloning a challenge, deeply clone the retry field if it is not nil.
Configuration menu - View commit details
-
Copy full SHA for 9f18882 - Browse repository at this point
Copy the full SHA 9f18882View commit details -
acme/challenge: Fix error return type on KeyAuthorization
In golang, one should always return error types rather than interfaces that conform to an error protocol. Why? Because of this: https://play.golang.org/p/MVa5vowuNRo Feels ~~like JavaScript~~ bad, man.
Configuration menu - View commit details
-
Copy full SHA for 089e3ae - Browse repository at this point
Copy the full SHA 089e3aeView commit details -
Remove superfluous test. Add test checking for the Retry-After header if the challenge's RetryAfter field is set.
Configuration menu - View commit details
-
Copy full SHA for 2514b58 - Browse repository at this point
Copy the full SHA 2514b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84af2ad - Browse repository at this point
Copy the full SHA 84af2adView commit details
Commits on May 13, 2020
-
acme/authority: Move comment onto correct block
The comment appeared too early.
Configuration menu - View commit details
-
Copy full SHA for 8556d45 - Browse repository at this point
Copy the full SHA 8556d45View commit details -
acme/api: Remove unused BackoffChallenge func
The mock has an old func that is no longer used. Remove it.
Configuration menu - View commit details
-
Copy full SHA for 794725b - Browse repository at this point
Copy the full SHA 794725bView commit details -
acme: Fix comment style to appease linter
The linter likes comments on public functions to start with their name, for some reason...
Configuration menu - View commit details
-
Copy full SHA for 8ae32f5 - Browse repository at this point
Copy the full SHA 8ae32f5View commit details -
acme/api: Write headers for invalid challenges
Include the "Link" and "Location" headers on invalid challenge resources. An invalid challenge is still a perfectly acceptable response.
Configuration menu - View commit details
-
Copy full SHA for 609e131 - Browse repository at this point
Copy the full SHA 609e131View commit details -
acme/authority: Fix error message in test
The error message was updated. Make the test should reflect the new changes.
Configuration menu - View commit details
-
Copy full SHA for b061d0a - Browse repository at this point
Copy the full SHA b061d0aView commit details -
Also, return early from ValidateChallenge if the challenge is already valid. Interestingly, we aren't actually testing most of the ValidateChallenge func, just the early error and return conditions. We should add some more coverage here.
Configuration menu - View commit details
-
Copy full SHA for 976c8f8 - Browse repository at this point
Copy the full SHA 976c8f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5354906 - Browse repository at this point
Copy the full SHA 5354906View commit details -
acme/api: Set Link and Location headers for all 200
On the challenge resource, set "Link" and "Location" headers for all successful requests to the challenge resource.
Configuration menu - View commit details
-
Copy full SHA for 5e5a76c - Browse repository at this point
Copy the full SHA 5e5a76cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8b3ca2 - Browse repository at this point
Copy the full SHA b8b3ca2View commit details
Commits on May 14, 2020
-
acme: Move ordinal to application
The authority now receives the ordinal in its constructor rather than a global variable set at package initialization time. The ordinal is passed via the command line option `--ordinal`.
Configuration menu - View commit details
-
Copy full SHA for c378e00 - Browse repository at this point
Copy the full SHA c378e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for f022818 - Browse repository at this point
Copy the full SHA f022818View commit details -
acme: Don't panic on logic errors
Since it will ultimately 500 anyway, just return an error.
Configuration menu - View commit details
-
Copy full SHA for deacbdc - Browse repository at this point
Copy the full SHA deacbdcView commit details
Commits on May 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d5f95de - Browse repository at this point
Copy the full SHA d5f95deView commit details
Commits on May 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9103880 - Browse repository at this point
Copy the full SHA 9103880View commit details -
acme: Update http-01 challenge tests
Add tests for the starting challenge statuses. Removed unneeded db write test.
Configuration menu - View commit details
-
Copy full SHA for 0f63e43 - Browse repository at this point
Copy the full SHA 0f63e43View commit details
Commits on May 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d54f963 - Browse repository at this point
Copy the full SHA d54f963View commit details -
acme/retry: Cleanup tls-alpn-01 tests
This logic was already in the correct form so it was much easier to update.
Configuration menu - View commit details
-
Copy full SHA for 0578055 - Browse repository at this point
Copy the full SHA 0578055View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c39439 - Browse repository at this point
Copy the full SHA 6c39439View commit details -
Add `golanglint-ci` to the modules so it's available when running `make lint`.
Configuration menu - View commit details
-
Copy full SHA for 112fc59 - Browse repository at this point
Copy the full SHA 112fc59View commit details