Switch from setuptools to a modern pyproject config #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Jul 17, 2024
.bumpversion.cfg
Outdated
There was a problem hiding this comment.
It didn't feel necessary to have a whole separate tool for this? Especially since it didn't even update non-python places we need to bump like Doxyfile (which may not live long, but still).
mikix
commented
Jul 17, 2024
| SMART FHIR Client | ||
| ================= | ||
| # SMART FHIR Client |
There was a problem hiding this comment.
We had a mix of underline and ## headers - consolidating on hashes, which are more obvious about what level you're at.
mikix
commented
Jul 17, 2024
Comment on lines
-214
to
+206
| python setup.py sdist | ||
| python setup.py bdist_wheel | ||
| python3 -m build |
There was a problem hiding this comment.
I tested the resulting sdist & and bdist from the new approach vs the old tarballs - new ones are still good.
dogversioning
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.