flask demo: don't provide a meaningless default server #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, ask the user to provide the test server. Which is annoying, but... The flask demo needs an OAuth-capable server, and we are currently using a no-auth server, so the user just sees a message "nothing to demo here". This is because: - The old server that presumably worked was taken down. - We put in the new R4 modern test server. - The modern server has a temporary bug where its metadata doesn't validate - So we didn't notice that the flask server wouldn't work even if validation passed. All of the public test servers I know about require you to email someone to set up a user. So it's not obvious what a good replacement would be. Honestly, we should probably just add a new default demo that supports no-auth servers and still shows something interesting. But for now, this gets the flask demo to a more honest place and asks the user to provide their own server. 🤷
dogversioning
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, ask the user to provide the test server. Which is annoying, but...
The flask demo needs an OAuth-capable server, and we are currently using a no-auth server, so the user just sees a message "nothing to demo here".
This is because:
All of the public test servers I know about require you to email someone to set up a user. So it's not obvious what a good replacement would be.
Honestly, we should probably just add a new default demo that supports no-auth servers and still shows something interesting.
But for now, this gets the flask demo to a more honest place and asks the user to provide their own server. 🤷
Fixes #162
Fixes #86