Use a full UUID4 for the state param #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
longer_state_param
branch
from
54b9a9b
to
8bd2bd7
Compare
mikix
force-pushed
the
longer_state_param
branch
from
8bd2bd7
to
edbfb79
Compare
Is this desire still relevant? I switched this PR to aim at main, where development of 4.2.0 is happening. |
@mikix Not at all. Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the hl7 SMART App Launch Implementation Guide:
The current state param used by this client is only 8 characters and, according to this entropy calculation, has only 41 bits of entropy.
The SMART App Launch Implementation Guide suggests using a "properly configured random uuid", which the uuid wiki indicates gives us the requisite 122 bits.
I'd like to have this in the 3.0 (STU3) version of the client, and also to merge it forward to master (R4).