Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing Best Practices #64

Open
wants to merge 2 commits into
base: argonaut-dev
Choose a base branch
from
Open

Initializing Best Practices #64

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2015

  1. Modified introduction to clarify intent
  2. Corrected a typo
  3. Added first two best practices

bakerdb added 2 commits July 16, 2015 16:49
Initializing Best Practices
3b84b43 
1) Modified introduction to clarify intent
2) Corrected a typo
3) Added first two best practices
Deleted entries 1-2
b33c7e9 
I think we should resolve what is needed w.r.t. server conformance before putting anything in the "Best Practices" section.  

I suspect the sponsors are looking for more than "best practices."
@jmandel
Copy link
Member

jmandel commented Nov 6, 2015

Thanks Dixie! I merged this branch and applied the following tweaks:
df7f9a6

Please let me know if they look okay. There were a couple of substantive points about the CSRF examples and token revocation mechanisms.

@ghost
Copy link
Author

ghost commented Nov 16, 2015

Thanks, Josh!

I've looked through the page and made some suggestions, mostly minor. Good addition to mention that authorization servers may ask end-users to accept or reject individual scopes. Also, eliminating the "you" references in the end-user session.

-Dixie

Dixie B. Baker, Ph.D.
Senior Partner
Martin, Blanck and Associates
Office (Redondo Beach, CA): 310-791-9671
Mobile: 310-279-2579

On Nov 6, 2015, at 2:57 PM, Josh Mandel <[email protected]mailto:[email protected]> wrote:

Thanks Dixie! I merged this branch and applied the following tweaks:
df7f9a6df7f9a6

Please let me know if they look okay. There were a couple of substantive points about the CSRF examples and token revocation mechanisms.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/64#issuecomment-154569114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmandel