Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Erroneous Approval Error #1125

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fixes Erroneous Approval Error #1125

merged 2 commits into from
Jul 1, 2024

Conversation

kalverra
Copy link
Collaborator

@kalverra kalverra commented Jul 1, 2024

Motivation

We were erroneously blocking you from calling approve() with too low of a balance. This doesn't reflect how things work on chain.

Solution

Remove that check

@kalverra kalverra requested review from jasonmci and a team as code owners July 1, 2024 17:14
jasonmci
jasonmci approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jasonmci jasonmci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@kalverra kalverra merged commit c0b080a into ccip-develop Jul 1, 2024
103 checks passed
@kalverra kalverra deleted the fixApprovalError branch July 1, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnieeG AnieeG AnieeG approved these changes

@jasonmci jasonmci jasonmci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalverra @jasonmci @AnieeG