Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump chainlink-common #1162

Merged
merged 9 commits into from
Jul 9, 2024
Merged

bump chainlink-common #1162

merged 9 commits into from
Jul 9, 2024

Conversation

0xnogo
Copy link
Contributor

@0xnogo 0xnogo commented Jul 9, 2024 •
edited
Loading

Bumping chainlink-common to latest available commit (smartcontractkit/chainlink-common@2444037)

Fixed a breaking change introduced by smartcontractkit/chainlink-common@dc1fbe4

Running:

  • make gomodtidy
  • make chainlink-dev (✅)

@0xnogo 0xnogo requested review from a team as code owners July 9, 2024 09:26
@makramkd
Copy link
Contributor

makramkd commented Jul 9, 2024

Can you run make gomodtidy and commit the result?

@makramkd
fix message hasher and tests (#1169)
b5489bd 
## Motivation

Fix the message hasher EVM implementation after the chainlink-common and
chainlink-ccip bumps which alter the `Message` type.

## Solution
@makramkd makramkd requested review from makramkd, elatoskinas, RayXpub and a team as code owners July 9, 2024 13:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

LCOV of commit 6ab6c25 during Solidity Foundry #6327

Summary coverage rate:
  lines......: 98.7% (1830 of 1855 lines)
  functions..: 96.3% (340 of 353 functions)
  branches...: 90.4% (756 of 836 branches)

Files changed coverage rate: n/a

makramkd
makramkd reviewed Jul 9, 2024
View reviewed changes
go.mod
@@ -45,7 +45,7 @@ require (
github.com/jackc/pgconn v1.14.3
github.com/jackc/pgtype v1.14.0
github.com/jackc/pgx/v4 v4.18.2
github.com/jmoiron/sqlx v1.3.5
github.com/jmoiron/sqlx v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem to be upgraded due to chainlink-common upgrades.

@makramkd makramkd merged commit 9a2b457 into ccip-develop Jul 9, 2024
107 checks passed
@makramkd makramkd deleted the Bump-chainlink-common branch July 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@chainchad chainchad chainchad approved these changes

@elatoskinas elatoskinas elatoskinas approved these changes

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xnogo @makramkd @elatoskinas @chainchad