Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable dynamic config setup on EVM2EVMMultiOffRamp contract creation #1175

Merged
merged 13 commits into from
Jul 12, 2024

Conversation

0xsuryansh
Copy link
Member

@0xsuryansh 0xsuryansh commented Jul 10, 2024

Motivation

For setting dynamic config in EVM2EVMMultiOffRamp, a separate transaction has to be sent for calling setDynamicConfig. As these parameters are known prior to contract deployment we can set these using the constructor

CCIP-2712

Solution

  • added DynamicConfig as a constructor parameter

@0xsuryansh 0xsuryansh requested a review from a team as a code owner July 10, 2024 07:41
Copy link
Contributor

github-actions bot commented Jul 10, 2024

LCOV of commit 50bda7d during Solidity Foundry #6504

Summary coverage rate:
  lines......: 98.7% (1829 of 1854 lines)
  functions..: 96.3% (341 of 354 functions)
  branches...: 90.4% (752 of 832 branches)

Files changed coverage rate: n/a

Signed-off-by: 0xsuryansh <[email protected]>
Signed-off-by: 0xsuryansh <[email protected]>
@0xsuryansh 0xsuryansh disabled auto-merge July 11, 2024 14:46
@0xsuryansh 0xsuryansh enabled auto-merge (squash) July 11, 2024 14:46
@makramkd
Copy link
Contributor

@0xsuryansh compilation failure after merging latest ccip-develop:

core/services/ocr3/plugins/ccip_integration_tests/helpers.go:167:4: not enough arguments in call to evm_2_evm_multi_offramp.DeployEVM2EVMMultiOffRamp
	have (*bind.TransactOpts, *backends.SimulatedBackend, evm_2_evm_multi_offramp.EVM2EVMMultiOffRampStaticConfig, []evm_2_evm_multi_offramp.EVM2EVMMultiOffRampSourceChainConfigArgs)
	want (*bind.TransactOpts, bind.ContractBackend, evm_2_evm_multi_offramp.EVM2EVMMultiOffRampStaticConfig, evm_2_evm_multi_offramp.EVM2EVMMultiOffRampDynamicConfig, []evm_2_evm_multi_offramp.EVM2EVMMultiOffRampSourceChainConfigArgs)

@0xsuryansh 0xsuryansh merged commit 50fae99 into ccip-develop Jul 12, 2024
102 checks passed
@0xsuryansh 0xsuryansh deleted the feat/CCIP-2712 branch July 12, 2024 16:24
0xnogo added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants