[TT-1396] [CCIP-2804] Migrate CCIP to test secrets #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing CI issues in testsecrets changes
kalverra
approved these changes
Aug 28, 2024
anirudhwarrier
approved these changes
Aug 28, 2024
momentmaker
approved these changes
Aug 28, 2024
b-gopalswami
approved these changes
Aug 28, 2024
AnieeG
approved these changes
Aug 28, 2024
|
AnieeG
pushed a commit
that referenced
this pull request
Aug 28, 2024
We're updating how we manage test secrets on GitHub CI to enhance security. Instead of passing secrets like the Chainlink image name or wallet key through secrets.toml, we will now load them from the `~/.testsecrets file in your home directory. This change helps us handle secrets more securely. To set test secrets, see instructions integration-tests/ccip-tests/testconfig/examples/.testsecrets.example --- TODO: - [x] @kalverra Run tests locally and see if all works fine - [ ] @kalverra Run all CI workflows and see if it all works fine - [x] @kalverra Update all documentation (docs in this repo are already updated by lukaszcl) - [x] @kalverra Notify CCIP developers that this change will be merged soon - [x] @lukaszcl Merge CTF PR which is a dependecy here https://github.com/smartcontractkit/chainlink-testing-framework/pull/1028/files - [x] @lukaszcl Update all CI workflows for CCIP - [x] @lukaszcl Update setup-create-base64-config-ccip in all workflows to correctly use output - [x] @lukaszcl Allow CI workflows to run with custom test secrets ([guide how to run it](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/config/README.md#run-github-workflow-with-your-test-secrets)) --------- Co-authored-by: Adam Hamrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating how we manage test secrets on GitHub CI to enhance security. Instead of passing secrets like the Chainlink image name or wallet key through secrets.toml, we will now load them from the `~/.testsecrets file in your home directory. This change helps us handle secrets more securely.
To set test secrets, see instructions integration-tests/ccip-tests/testconfig/examples/.testsecrets.example
TODO: