-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test Setup Nodes and Add DON [CCIP-2810] #1190
Conversation
General setup for ocr3 nodes
@@ -1,4 +1,4 @@ | |||
package home_chain | |||
package ccip_integration_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the file up one directory, no need to review changes.
665cf9b
to
85f3692
Compare
4479b7d
to
5d1f229
Compare
tickCtx, tickCancel := context.WithCancel(testutils.Context(t)) | ||
defer tickCancel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this'll work, tickCancel() will be called likely before the goroutine is scheduled. You can keep it in the Cleanup
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even think you need this extra ctx, you can just watch Done() on testutils.Context(t)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm there might be something interesting.
func TestFlk(t *testing.T) {
for i := 0; i < 20; i++ {
TestIntegration_OCR3Nodes(t)
}
}
Can you try to see if this ^ fails?
I believe there's some db resource that needs to be cleaned up after the test finishes.
core/services/ocr3/plugins/ccip_integration_tests/ocr3_node_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ocr_node_helper.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ocr3_node_test.go
Outdated
Show resolved
Hide resolved
I tested 100 times and it passed them all. Do you get any issues locally? |
a8bc052
to
6fe6563
Compare
6fe6563
to
1b3cec4
Compare
1b3cec4
to
6012743
Compare
core/services/ocr3/plugins/ccip_integration_tests/ocr_node_helper.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ocr3_node_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ocr3_node_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ocr_node_helper.go
Outdated
Show resolved
Hide resolved
2002c27
to
dc6021e
Compare
Setting up a basic test that have basic OCR3 Nodes. Each Node can access 3 EVM chains that are created and connected to each others. Check PR for more details on creating the chains and connecting them.
As JobSpecs for CCIP are not ready. The main goal of this PR is to have the nodes and AddDon on capability registry for these nodes for each chain. Once JobSpec is ready we'll be able to test that the nodes picks up the changes and deploys the plugins, start sending, receiving,..etc.