Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network input with env var #121

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Sep 8, 2023

Motivation

The current way of providing network input to test is through SELECTED_NETWORKS env var. If we need to run tests in more than 2 networks over multiple lanes, the network input in SELECTED_NETWORKS runs the test for all possible combination of lanes between 2 networks among all provided networks. For example with SELECTED_NETWORKS=networkA, NetworkB, NetworkC the test is triggered for all possible combination of these networks - A,B ; B,C; A,C
Often we need to run tests for only specific set of lanes between various networks.

Solution

Introduce another env var CCIP_NETWORK_PAIRS example usage - CCIP_NETWORK_PAIRS="networkA,networkB|networkC,networkD|networkA,networkC"
It's|delimited list of network pairs. It will help us specify lanes on which tests are to be triggered as opposed to all possible combination of lanes

@AnieeG AnieeG requested a review from a team as a code owner September 8, 2023 00:49
@AnieeG AnieeG requested review from kalverra and jasonmci September 8, 2023 00:52
@AnieeG AnieeG force-pushed the ccip-1021-add-network-input branch from db91df2 to 9d190be Compare September 8, 2023 19:24
@AnieeG AnieeG merged commit 697ae59 into ccip-develop Sep 8, 2023
65 checks passed
@AnieeG AnieeG deleted the ccip-1021-add-network-input branch September 8, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants