use transferFrom(pool -> receiver) over hop through offRamp #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
changed the title
RensR
changed the title
LCOV of commit
|
RayXpub
reviewed
Aug 5, 2024
# Conflicts: # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
elatoskinas
approved these changes
Aug 6, 2024
| @@ -478,7 +478,7 @@ contract TokenPoolAndProxy is EVM2EVMOnRampSetup { | |||
| vm.startPrank(address(s_fakeOffRamp)); | |||
|
|
|||
| vm.expectEmit(address(s_legacyPool)); | |||
| emit Minted(address(s_pool), s_fakeOffRamp, amount); | |||
| emit Minted(address(s_pool), address(s_pool), amount); | |||
There was a problem hiding this comment.
suggestion: we should verify the Approve event as well
elatoskinas
reviewed
Aug 6, 2024
| ); | ||
| i_token.approve(msg.sender, releaseOrMintIn.amount); |
There was a problem hiding this comment.
q: shouldn't we check the bool output value and revert if it's false in all approve instances?
Although this would bubble up to the transferFrom function failing in the OffRamp, so not strictly necessary
There was a problem hiding this comment.
We want to keep these function as low in gas as possible, so given this isn't strictly necessary I'd vote to do it through the implicit check over explicit
RayXpub
approved these changes
Aug 6, 2024
makramkd
approved these changes
Aug 6, 2024
Merged
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # core/gethwrappers/ccip/generated/evm_2_evm_multi_offramp/evm_2_evm_multi_offramp.go # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
|
RensR
added a commit
that referenced
this pull request
Aug 9, 2024
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
## Motivation Change the hop through the offRamp to a transferFrom so the funds never touch CCIP contracts outside of the pool ## Solution
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change the hop through the offRamp to a transferFrom so the funds never touch CCIP contracts outside of the pool
Solution