Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-3007 : Add script for zksync compile contract #1276

Merged
merged 23 commits into from
Sep 5, 2024
Merged

CCIP-3007 : Add script for zksync compile contract #1276

merged 23 commits into from
Sep 5, 2024

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Aug 8, 2024

Motivation

Solution

@AnieeG AnieeG requested review from makramkd, elatoskinas, RayXpub and a team as code owners August 8, 2024 20:44
matYang
matYang reviewed Aug 23, 2024
View reviewed changes
contracts/hardhat.ccip.zksync.config.ts Outdated
dockerImage: '',
tag: '',
},
contractsToCompile: ['RMN', 'ARMProxy'], // uncomment this to compile only specific contracts
Copy link
Collaborator

@matYang matYang Aug 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we always compile the entire list of contracts you need, so local artifacts are always latest, to reduce risk with outdated artifacts being copied to G++

@AnieeG AnieeG enabled auto-merge (squash) August 23, 2024 18:24
@AnieeG AnieeG requested review from a team as code owners August 28, 2024 23:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

LCOV of commit e03697e during Solidity Foundry #8033

Summary coverage rate:
  lines......: 97.6% (2154 of 2206 lines)
  functions..: 94.9% (408 of 430 functions)
  branches...: 93.4% (512 of 548 branches)

Files changed coverage rate: n/a

@AnieeG AnieeG force-pushed the ccip-3007-zksync-compile branch from 88fe3b9 to ba9f3bb Compare August 29, 2024 16:46
simsonraj
simsonraj reviewed Sep 5, 2024
View reviewed changes
contracts/scripts/zksyncverify/README.md
```

This will generate the constructor arguments which you can use to in [zksync-verify.ts](zksync-verify.ts) script.
Replace the constructor arguments and contract address in the script and run the following command from [contracts](../../) dir to verify the contract:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add another point here.
The generated constructor arguments may not be in the right order, Cross check the order of the constructor arguments, structs & its fields against the constructor in the respective solidity file

@AnieeG AnieeG merged commit 95ffd86 into ccip-develop Sep 5, 2024
127 checks passed
@AnieeG AnieeG deleted the ccip-3007-zksync-compile branch September 5, 2024 19:55
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR left review comments

@simsonraj simsonraj simsonraj approved these changes

@matYang matYang matYang approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnieeG @matYang @simsonraj @RensR