open zeppelin v 5 migration #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LCOV of commit
|
RyanRHall
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
RyanRHall
changed the title
RayXpub
reviewed
Aug 12, 2024
| @@ -20,7 +20,7 @@ import {Pool} from "../libraries/Pool.sol"; | |||
| import {MultiOCR3Base} from "../ocr/MultiOCR3Base.sol"; | |||
|
|
|||
| import {IERC20} from "../../vendor/openzeppelin-solidity/v4.8.3/contracts/token/ERC20/IERC20.sol"; | |||
There was a problem hiding this comment.
suggestion: I think we can use 5.0.2 here?
RayXpub
approved these changes
Aug 12, 2024
RayXpub
approved these changes
Aug 12, 2024
RyanRHall
force-pushed
the
origin/CCIP-2599-open-zeppelin-v-5-migration-2
branch
from
2a6398a to
743eec9
Compare
elatoskinas
approved these changes
Aug 12, 2024
|
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
## Motivation Use the latest version of deps ## Solution Upgrade OZ deps to latest version ## Implementation Notes `IERC20` and `SafeERC20` are kept on `4.8.3` because of the `^0.8.20` requirement OZ imposes on the v5 contracts. We can't upgrade these deps until the rest of the contract codebase upgrades to 0.8.20+ --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use the latest version of deps
Solution
Upgrade OZ deps to latest version
Implementation Notes
IERC20andSafeERC20are kept on4.8.3because of the^0.8.20requirement OZ imposes on the v5 contracts. We can't upgrade these deps until the rest of the contract codebase upgrades to 0.8.20+