aggregate token and gas price heartbeat updates into batches #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
approved these changes
Aug 12, 2024
mateusz-sekara
approved these changes
Aug 12, 2024
|
matYang
added a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Price reporting frequencies have been turned to following values on Eth mainnet (where most price update costs is) ``` GasHeartBeat: 2hr ExecGasPriceDeviation: 400% DAPriceDeviation: 400% TokenPriceHeartBeat: 12hr TokenPriceDeviation: 20% ``` As a result, updates are mostly heartbeat driven as opposed to deviation driven. A simple trick to improve leader-lane batching is to always batch report all heartbeat prices. In clam environments where prices are heartbeat driven, this absolutely minimizes number of price reports. In flux environments where good number of prices are deviation driven while some remain heartbeat driven, e.g. in case of Eth blob base fee spike, the penalty we take for including each additional prices is low (~6k gas) v.s the OCR tx overhead (~110k gas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Price reporting frequencies have been turned to following values on Eth mainnet (where most price update costs is)
As a result, updates are mostly heartbeat driven as opposed to deviation driven. A simple trick to improve leader-lane batching is to always batch report all heartbeat prices.
In clam environments where prices are heartbeat driven, this absolutely minimizes number of price reports.
In flux environments where good number of prices are deviation driven while some remain heartbeat driven, e.g. in case of Eth blob base fee spike, the penalty we take for including each additional prices is low (~6k gas) v.s the OCR tx overhead (~110k gas)