Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pool func visibility #1283

Merged
merged 8 commits into from
Aug 12, 2024
Merged

update pool func visibility #1283

merged 8 commits into from
Aug 12, 2024

Conversation

matYang
Copy link
Collaborator

@matYang matYang commented Aug 12, 2024

Motivation

Solution

@matYang matYang requested review from RensR and jhweintraub August 12, 2024 05:35
@matYang matYang requested review from makramkd, elatoskinas, RayXpub and a team as code owners August 12, 2024 05:35
@matYang matYang changed the title update pool funcs update pool func visibility Aug 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

LCOV of commit 99b1d43 during Solidity Foundry #7185

Summary coverage rate:
  lines......: 98.7% (1882 of 1907 lines)
  functions..: 96.4% (347 of 360 functions)
  branches...: 90.6% (797 of 880 branches)

Files changed coverage rate: n/a

@matYang matYang requested a review from a team as a code owner August 12, 2024 14:37
RensR
RensR reviewed Aug 12, 2024
View reviewed changes
contracts/src/v0.8/ccip/pools/USDC/USDCTokenPool.sol Outdated
@@ -93,13 +93,32 @@ contract USDCTokenPool is TokenPool, ITypeAndVersion {
emit ConfigSet(address(tokenMessenger));
}

/// @notice Burns USDC in the pool
/// @dev invokes underlying CCTP protocol
function lockOrBurn(Pool.LockOrBurnInV1 calldata lockOrBurnIn)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making them public feels a lot cleaner

@matYang matYang enabled auto-merge (squash) August 12, 2024 15:08
@matYang matYang merged commit 151487c into ccip-develop Aug 12, 2024
108 checks passed
@matYang matYang deleted the pool-function-viz branch August 12, 2024 15:25
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

dhaidashenko pushed a commit that referenced this pull request Sep 2, 2024
@matYang @asoliman92
update pool func visibility (#1283)
bbe2795 
## Motivation


## Solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatoskinas elatoskinas elatoskinas approved these changes

@RensR RensR RensR approved these changes

@jhweintraub jhweintraub Awaiting requested review from jhweintraub

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matYang @RensR @elatoskinas