Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sequence number #1290

Closed
wants to merge 2 commits into from
Closed

Rename sequence number #1290

wants to merge 2 commits into from

Conversation

RyanRHall
Copy link
Contributor

Motivation

"Sequence number" is confusing because it's used in OCR and CCIP

Solution

Rename CCIP's "sequence number" to "message number"

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit a35fcee during Solidity Foundry #7214

Summary coverage rate:
  lines......: 98.7% (1882 of 1907 lines)
  functions..: 96.4% (347 of 360 functions)
  branches...: 90.6% (797 of 880 branches)

Files changed coverage rate: n/a

andrevmatos
andrevmatos requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@andrevmatos andrevmatos left a comment •
edited by elatoskinas
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not? This will break a LOT of things in Atlas, and even if it's just for v1.6, this is gonna make our "backwards-compatible" data model work way harder to pull off. These variables are used in different contexts, I think we should be able to split them in mind?

@RyanRHall
Copy link
Contributor Author

closing in favor of #1331

@RyanRHall RyanRHall closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrevmatos andrevmatos andrevmatos requested changes

@makramkd makramkd Awaiting requested review from makramkd makramkd will be requested when the pull request is marked ready for review makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas will be requested when the pull request is marked ready for review elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub will be requested when the pull request is marked ready for review RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanRHall @andrevmatos