Do not return the error in case if onRamp not initialized #1487
Conversation
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
force-pushed
the
hotfix/DAGasPriceInit
branch
from
f514173 to
d6b78b8
Compare
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
|
| @@ -42,7 +41,7 @@ func (c *FeeEstimatorConfigService) SetOnRampReader(reader ccip.OnRampReader) { | |||
| // GetDynamicConfig should be cached in the onRamp reader to avoid unnecessary on-chain calls | |||
| func (c *FeeEstimatorConfigService) GetDataAvailabilityConfig(ctx context.Context) (destDataAvailabilityOverheadGas, destGasPerDataAvailabilityByte, destDataAvailabilityMultiplierBps int64, err error) { | |||
| if c.onRampReader == nil { | |||
| return 0, 0, 0, errors.New("no OnRampReader has been configured") | |||
There was a problem hiding this comment.
Can you share some reasoning behind this decision? IIUC this will return 0s to daOverheadGas, gasPerDAByte, daMultiplier. Does the calling function know how to handle that case? What would happen to estimateDACostUSD when 0s are returned?
There was a problem hiding this comment.
@mateusz-sekara Calling this function will multiply gasPrice with 0 and return 0 DAGasPrice
https://github.com/smartcontractkit/ccip/blob/ccip-develop/core/services/ocr2/plugins/ccip/prices/da_price_estimator.go#L182
Then just added 0 gas price to the estimatedExecCost
https://github.com/smartcontractkit/ccip/blob/ccip-develop/core/services/ocr2/plugins/ccip/prices/da_price_estimator.go#L154
This is worked in the same way before this feature been implemented
There was a problem hiding this comment.
Okay, I would consider some warning log in this if if that's something that should not happen
## Motivation For the exec provider, in some cases, the onRamp reader is not initialized. For immediate reaction, we need to allow execution without blocking in cases if onRamp is not initialized. It fails due the issue when onRampReader is not initialized for execProvider. This fix should fix this issue. In case the onRamp reader is not initialized, the module will return 0 values and DAGasEstimator will behave as it worked before this feature been implemented.
Motivation
For the exec provider, in some cases, the onRamp reader is not initialized. For immediate reaction, we need to allow execution without blocking in cases if onRamp is not initialized. It fails due the issue when onRampReader is not initialized for execProvider. This fix should fix this issue. In case the onRamp reader is not initialized, the module will return 0 values and DAGasEstimator will behave as it worked before this feature been implemented.