set FinalityTagBypass=false for chains with FinalityDepth<1k #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevmatos
approved these changes
Nov 8, 2024
Madalosso
requested review from
simsonraj,
HelloKashif,
stackman27,
friedemannf and
finleydecker
…ality-tag-bypass # Conflicts: # core/chains/evm/config/toml/defaults/BOB_Testnet.toml # core/chains/evm/config/toml/defaults/Linea_Mainnet.toml # core/chains/evm/config/toml/defaults/Linea_Sepolia.toml # core/chains/evm/config/toml/defaults/Polygon_Zkevm_Cardona.toml # core/chains/evm/config/toml/defaults/XLayer_Sepolia.toml
…madalosso/finality-tag-bypass
KodeyThomas
approved these changes
Dec 13, 2024
friedemannf
pushed a commit
that referenced
this pull request
Dec 13, 2024
bukata-sa
added a commit
that referenced
this pull request
Dec 13, 2024
…1576) ## Motivation https://chainlink-core.slack.com/archives/C07RA1B58CC/p1730983397689179?thread_ts=1730908333.814809&cid=C07RA1B58CC ## Solution ## Motivation ## Solution --------- Co-authored-by: Otávio Migliavacca Madalosso <[email protected]> Co-authored-by: Aleksandr Bukata <[email protected]>
bukata-sa
added a commit
that referenced
this pull request
Dec 17, 2024
…#1580) Reverts #1526 During release we have noticed big amount of errors from head_tracker ` {"level":"crit","ts":"2024-12-17T16:45:40.464Z","logger":"EVM.43114.HeadTracker","caller":"headtracker/head_tracker.go:196","msg":"invariant violation: expected head of canonical chain to be ahead of the latestFinalized","version":"2.17.0-ccip1.5.14@a0e08e1","head_block_num":54475496,"latest_finalized_block_number":54475497,"sentryEventID":null,"stacktrace":"github.com/smartcontractkit/chainlink/v2/common/headtracker.(*headTracker[...]).Backfill\n\t/chainlink/common/headtracker/head_tracker.go:196\ngithub.com/smartcontractkit/chainlink/v2/common/headtracker.(*headTracker[...]).backfillLoop\n\t/chainlink/common/headtracker/head_tracker.go:307\ngithub.com/smartcontractkit/chainlink-common/pkg/services.(*Engine).Go.func1\n\t/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/services/service.go:61"}`
bukata-sa
added a commit
that referenced
this pull request
Dec 17, 2024
…#1580) Reverts #1526 During release we have noticed big amount of errors from head_tracker ` {"level":"crit","ts":"2024-12-17T16:45:40.464Z","logger":"EVM.43114.HeadTracker","caller":"headtracker/head_tracker.go:196","msg":"invariant violation: expected head of canonical chain to be ahead of the latestFinalized","version":"2.17.0-ccip1.5.14@a0e08e1","head_block_num":54475496,"latest_finalized_block_number":54475497,"sentryEventID":null,"stacktrace":"github.com/smartcontractkit/chainlink/v2/common/headtracker.(*headTracker[...]).Backfill\n\t/chainlink/common/headtracker/head_tracker.go:196\ngithub.com/smartcontractkit/chainlink/v2/common/headtracker.(*headTracker[...]).backfillLoop\n\t/chainlink/common/headtracker/head_tracker.go:307\ngithub.com/smartcontractkit/chainlink-common/pkg/services.(*Engine).Go.func1\n\t/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/services/service.go:61"}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://chainlink-core.slack.com/archives/C07RA1B58CC/p1730983397689179?thread_ts=1730908333.814809&cid=C07RA1B58CC
Solution