Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOB fixing finality depth in mainnet #1545

Merged
merged 1 commit into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/chains/evm/config/toml/defaults/BOB_Mainnet.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ChainID = '60808'
# OP stack https://docs.gobob.xyz/learn/introduction/stack-overview#rollup-layer
ChainType = 'optimismBedrock'
# finality_depth was: ~850
FinalityDepth = 900
# FinalityDepth in mainnet showed more than 3k
FinalityDepth = 3150
# block_time was: 2s, adding 1 second buffer
LogPollInterval = '3s'

# finality_depth * block_time / 60 secs = ~30 min (finality time)
NoNewFinalizedHeadsThreshold = '35m'
# finality_depth * block_time / 60 secs = ~105 min (finality time)
NoNewFinalizedHeadsThreshold = '110m'

FinalityTagEnabled = true

Expand Down
8 changes: 4 additions & 4 deletions core/chains/evm/config/toml/defaults/BOB_Testnet.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ChainID = '808813'
# OP stack https://docs.gobob.xyz/learn/introduction/stack-overview#rollup-layer
ChainType = 'optimismBedrock'
# finality_depth was: ~850
FinalityDepth = 900
# FinalityDepth in mainnet showed more than 3k
FinalityDepth = 3150
# block_time was: 2s, adding 1 second buffer
LogPollInterval = '3s'

# finality_depth * block_time / 60 secs = ~30 min (finality time)
NoNewFinalizedHeadsThreshold = '35m'
# finality_depth * block_time / 60 secs = ~105 min (finality time)
NoNewFinalizedHeadsThreshold = '110m'

FinalityTagEnabled = true

Expand Down
8 changes: 4 additions & 4 deletions docs/CONFIG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8368,7 +8368,7 @@ AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
ChainType = 'optimismBedrock'
FinalityDepth = 900
FinalityDepth = 3150
FinalityTagEnabled = true
LogBackfillBatchSize = 1000
LogPollInterval = '3s'
Expand All @@ -8383,7 +8383,7 @@ LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '35m0s'
NoNewFinalizedHeadsThreshold = '1h50m0s'

[Transactions]
ForwardersEnabled = false
Expand Down Expand Up @@ -9712,7 +9712,7 @@ AutoCreateKey = true
BlockBackfillDepth = 10
BlockBackfillSkip = false
ChainType = 'optimismBedrock'
FinalityDepth = 900
FinalityDepth = 3150
FinalityTagEnabled = true
LogBackfillBatchSize = 1000
LogPollInterval = '3s'
Expand All @@ -9727,7 +9727,7 @@ LogBroadcasterEnabled = true
RPCDefaultBatchSize = 250
RPCBlockQueryDelay = 1
FinalizedBlockOffset = 0
NoNewFinalizedHeadsThreshold = '35m0s'
NoNewFinalizedHeadsThreshold = '1h50m0s'

[Transactions]
ForwardersEnabled = false
Expand Down
Loading