CCIP-4408: E2E test for LBTC #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TokenPool contract constructor works when you set the decimal arg to 18 instead of 6
b-gopalswami
force-pushed
the
ccip-4408
branch
from
89faf57 to
4081a34
Compare
b-gopalswami
requested review from
a team,
makramkd,
elatoskinas and
RayXpub
as code owners
rstout
approved these changes
Dec 9, 2024
rstout
approved these changes
Dec 11, 2024
AnieeG
approved these changes
Dec 11, 2024
Tofel
reviewed
Dec 11, 2024
Tofel
reviewed
Dec 11, 2024
Tofel
reviewed
Dec 11, 2024
Tofel
reviewed
Dec 11, 2024
| rmnContract := *ccipModule.RMNContract | ||
| destPoolData, err := hex.DecodeString(LBTCValidDestPoolData) // valid 32 bytes should call attestation api | ||
| if err != nil { | ||
| return fmt.Errorf("decoding dest pool data shouldn't fail %w", err) |
There was a problem hiding this comment.
I think that errors.Wrapf would be much more useful as it would also give you the whole stacktrace. That function comes from "github.com/pkg/errors"
Tofel
approved these changes
Dec 11, 2024
RensR
reviewed
Dec 12, 2024
RensR
reviewed
Dec 12, 2024
RensR
reviewed
Dec 12, 2024
RensR
reviewed
Dec 12, 2024
| @@ -925,6 +932,16 @@ func (ccipModule *CCIPCommon) DeployContracts( | |||
| if err != nil { | |||
| return fmt.Errorf("granting minter role to token transmitter shouldn't fail %w", err) | |||
| } | |||
| } else if ccipModule.IsLBTCDeployment() && i == 0 { | |||
| // if it's LBTC deployment, we deploy the burn mint token 677 with decimal 8 and cast it to ERC20Token | |||
| lbtcToken, err := ccipModule.tokenDeployer.DeployCustomBurnMintERC677Token("Lombard LBTC", "LBTC", uint8(8), new(big.Int).Mul(big.NewInt(1e6), big.NewInt(1e18))) | |||
There was a problem hiding this comment.
Probably better to specify this in deployment/ccip/changeset/token_info.go
There was a problem hiding this comment.
This is in CCIP repo and I don't find that path. We have that in Chainlink repo but not in CCIP.
RensR
reviewed
Dec 12, 2024
| @@ -962,6 +962,32 @@ runner-test-matrix: | |||
| E2E_TEST_SELECTED_NETWORK: SIMULATED_1,SIMULATED_2 | |||
| test_config_override_path: integration-tests/ccip-tests/testconfig/tomls/usdc_mock_deployment.toml | |||
|
|
|||
| - id: ccip-smoke-lbtc-32bytes-destination-pool-data | |||
There was a problem hiding this comment.
Do we really need two entire smoke tests for the minor difference in tx types? Can't we just use one test and send both txs?
There was a problem hiding this comment.
The test TestSmokeCCIPForBidirectionalLane which is used here is common one and this LBTC functionality is driven by config values in that test. This approach avoids adding new set of test and also running it using separate runner parallelize it.
makramkd
approved these changes
Dec 13, 2024
jhweintraub
approved these changes
Dec 13, 2024
bukata-sa
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Motivation Adding two E2E test to validate Lombard integration. Test-1: Make sure the destination payload data from mock token pool is sent as 32 bytes and that triggers call attestation API enabled flow. Mock attestation API provides the required attestation and token transfer should be successful. Test-2: Send non 32 bytes destination payload data form mock token pool and that should trigger attestation disabled flow and the token transfer should be successful. ## Solution --------- Co-authored-by: Ryan Stout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding two E2E test to validate Lombard integration.
Test-1: Make sure the destination payload data from mock token pool is sent as 32 bytes and that triggers call attestation API enabled flow. Mock attestation API provides the required attestation and token transfer should be successful.
Test-2: Send non 32 bytes destination payload data form mock token pool and that should trigger attestation disabled flow and the token transfer should be successful.
Solution