CCIP-1147 - Cache last update #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
reviewed
Oct 12, 2023
jarnaud
changed the base branch from
ccip-develop
to
perf/ccip736-optimize-price-updates-fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
getLatestGasPriceUpdate, if no inflight is present (or if inflight is not used),destPriceRegistryReaderis always called over the entire gas price heartbeat.In many cases the same data are queried several time, and we could therefore keep the results previously retrieved.
Solution
This PR add a cache mechanism to keep the latest update in cache, and use its timestamp as the starting point from when to query the new price updates.