Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP 1766 - Curse And Uncurse RMN and soak #602

Merged
merged 19 commits into from
Mar 12, 2024
Merged

CCIP 1766 - Curse And Uncurse RMN and soak #602

merged 19 commits into from
Mar 12, 2024

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Mar 8, 2024 •
edited
Loading

Motivation

Validate cursing halts the lane for 30 min.

Solution

Added test TestLoadCCIPStableRPSAfterARMCurseAndUncurse

  • ValidateCurseFollowedByUncurse assumes the lanes under test are bi-directional.
  • It curses source ARM for forward lanes so that destination curse is also validated for reverse lanes.
  • It waits for 5 minutes for curse to be seen by ccip plugins and contracts.
  • It captures the curse timestamp to verify no execution state changed event is emitted after the curse is applied.
  • It uncurses the source ARM at the end so that it can be verified that rest of the requests are processed as expected.
  • Validates that even after uncursing the lane should not (generate any ReportAccepted and ExecutionState Changed event) function for 30 more minutes.

@AnieeG AnieeG requested review from jasonmci and a team as code owners March 8, 2024 21:32
Tofel
Tofel reviewed Mar 11, 2024
View reviewed changes
integration-tests/ccip-tests/load/helper.go
}
errGrp.Go(func() error {
lane.Logger.Info().Msg("Validating no CommitReportAccepted event is received for 29 minutes")
return lane.Dest.AssertNoReportAcceptedEventReceived(lane.Logger, 29*time.Minute, curseTimeStamp.Add(30*time.Second))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add 30sec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a buffer, to ensure that if already some transmission txs are in mempool by the time it was cursed, those txs might generate some events when gets confirmed. Adding 30s to let all pending txs go through and then check for the events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you cannot be sure mempool is empty, why not check it?

@AnieeG AnieeG force-pushed the ccip-1766-curse-uncurse-RMN-and-soak branch from 5976692 to 9298f85 Compare March 12, 2024 18:17
@AnieeG AnieeG merged commit afe6c98 into ccip-develop Mar 12, 2024
70 checks passed
@AnieeG AnieeG deleted the ccip-1766-curse-uncurse-RMN-and-soak branch March 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara left review comments

@Tofel Tofel Tofel approved these changes

@jasonmci jasonmci Awaiting requested review from jasonmci

@RensR RensR Awaiting requested review from RensR

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnieeG @mateusz-sekara @Tofel