Check if DNS records exist before posting comment with subdomains #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
requested review from
RensR,
connorwstein,
jasonmci and
a team
as code owners
CRIB Environment Details ℹ️CRIB activated via the 'crib' label. To destroy the environment, remove the 'crib' PR label or close the PR. Please review the following details: SubdomainsUse these subdomains to access the CRIB environment. They are prefixes to the internal base domain which work over the VPN.
NOTE: If you have trouble resolving these subdomains, please try to reset your VPN DNS and/or local DNS. |
mateusz-sekara
approved these changes
Mar 14, 2024
AnieeG
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When setting up a CRIB, we make a PR comment with the subdomains. We don't want to post those subdomains unless they have been propagated.
Solution
Check AWS Route 53 for these records and then post the comment with the subdomain records.