CCIP-1876 Simplify background worker and implement ServiceCtx #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
force-pushed
the
service-ctx-for-bg-workers
branch
from
d0c2dec to
5b13060
Compare
mateusz-sekara
force-pushed
the
service-ctx-for-bg-workers
branch
from
5b13060 to
fde2e03
Compare
dimkouv
reviewed
Mar 15, 2024
| @@ -164,9 +163,9 @@ func (c *chainHealthcheck) Close() error { | |||
| } | |||
|
|
|||
| func (c *chainHealthcheck) run() { | |||
| defer c.wg.Done() | |||
There was a problem hiding this comment.
I would expect many issues the way we had this so far, why we didn't spot it earlier?
There was a problem hiding this comment.
This change was introduced 2 days ago and never deployed
dimkouv
approved these changes
Mar 15, 2024
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Solution * Register TokenBackgroundWorker properly using ServiceCtx * Simplify a bit by using `go-cache` instead of custom implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
go-cacheinstead of custom implementation