Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SHIP-1481) Increase default LimitDefault for CCIP #664

Merged
merged 53 commits into from
Jul 11, 2024

Conversation

HelloKashif
Copy link
Collaborator

@HelloKashif HelloKashif commented Apr 1, 2024

LimitDefault of 8M is the most common value used in chains so setting this as the default

@HelloKashif HelloKashif requested a review from simsonraj April 1, 2024 13:39
@HelloKashif HelloKashif requested a review from a team as a code owner April 1, 2024 13:39
Copy link
Contributor

github-actions bot commented Apr 1, 2024

I see you updated files related to core. Please run pnpm changeset to add a changeset.

HelloKashif and others added 2 commits May 30, 2024 14:40
## Motivation

Fixed the test failures 

## Solution

Updated the relevant values in the test files and docs
## Motivation

Failing tests due to mismatch in CONFIG.md

## Solution

Update LimitDefault and LimitMax in CONFIG.md

---------

Co-authored-by: Kashif Siddiqui <[email protected]>
@simsonraj simsonraj self-requested a review July 2, 2024 08:56
Copy link
Contributor

@mateusz-sekara mateusz-sekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor question about change in the CI files

.github/workflows/integration-tests.yml Show resolved Hide resolved
@amaechiokolobi amaechiokolobi changed the title Increase default LimitDefault for CCIP (SHIP-1481) Increase default LimitDefault for CCIP Jul 8, 2024
Copy link
Contributor

@jasonmci jasonmci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

auto-merge was automatically disabled July 11, 2024 17:00

Merge commits are not allowed on this repository

@amaechiokolobi amaechiokolobi merged commit 73a608a into ccip-develop Jul 11, 2024
107 checks passed
@amaechiokolobi amaechiokolobi deleted the kashif/limit-default branch July 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants