Upstream 2.10-rc3 merge #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to core. Please run |
makramkd
reviewed
Apr 5, 2024
There was a problem hiding this comment.
I don't think these need to be added right?
There was a problem hiding this comment.
Hmm, dunno, this is exactly what was committed in Core repo
https://github.com/smartcontractkit/chainlink/blob/develop/core/web/assets/main.4a9b933093bb165fcc8f.js
If it shouldn't be there, let them fix in the upstream instead of removing it manually from our repo
There was a problem hiding this comment.
Yeah I just saw that. I don't think it affects the build process so should be fine.
|
Looks like the upstream PR included some unnecessary files smartcontractkit/chainlink#12684 |
makramkd
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution