rm offchain check for token pool rate limits #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to core. Please run |
RensR
force-pushed
the
rm-offchain-dest-pool-rate-limit-checks
branch
from
ec2dd40 to
d8f51d8
Compare
| ) (executableMessages []ccip.ObservedMessage) { | ||
| inflightAggregateValue, inflightTokenAmounts, err := inflightAggregates(inflight, destTokenPricesUSD, sourceToDestToken) | ||
| inflightAggregateValue, _, err := inflightAggregates(inflight, destTokenPricesUSD, sourceToDestToken) |
There was a problem hiding this comment.
Probably you can remove computing inflightTokenAmounts entirely from inflightAggregates fun
| @@ -385,11 +305,6 @@ func (r *ExecutionReportingPlugin) buildBatch( | |||
| continue | |||
| } | |||
|
|
|||
| if !r.isRateLimitEnoughForTokenPool(destTokenPoolRateLimits, msg.TokenAmounts, inflightTokenAmounts, sourceToDestToken) { | |||
There was a problem hiding this comment.
Please remove that function (isRateLimitEnoughForTokenPool) from the codebase
mateusz-sekara
approved these changes
Apr 8, 2024
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Motivation Self serve will allow for token pools that do not have all the functions we currently call offchain After this PR we assume it will go through due to the same rate limits being enforced onchain on send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Self serve will allow for token pools that do not have all the functions we currently call offchain
After this PR we assume it will go through due to the same rate limits being enforced onchain on send