Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in Aggregate Rate Limiter #698

Closed
wants to merge 50 commits into from
Closed

Opt-in Aggregate Rate Limiter #698

wants to merge 50 commits into from

Conversation

justinkaseman
Copy link
Collaborator

@justinkaseman justinkaseman commented Apr 9, 2024 •
edited
Loading

Motivation

Currently, all token pools on a given lane are included in its ARL (Aggregate Rate Limiter). With permissonless token pools there may no longer be a price being reported for every token. ARL'ing should instead be opt-in, only when the pricegetter has been configured.

Solution

Add an additional piece of configuration per token for whether or not to include it in the ARL total.
This defaults to off, requiring admin/owner action to opt-in a token before it is included.

RensR added 30 commits March 4, 2024 11:45
@RensR
rm tokens from ramps
b111359
@RensR
add remote pool config to pool
60b19b0
@RensR
token setup
5ad0364
@RensR
fix pool return values & parsing
0c2b602
@RensR
Merge branch 'ccip-develop' into permissionless-token-pools-demo
1657c8c
@RensR
add mapping for token -> pool in token setup
8e0fe16
@RensR
rm pools and tokens from offRamp unit
9fea02d
@RensR
fix offramp setting TokenDataPayload
123638a
@RensR
fix usdc & lockRelease pool
a84800a
@RensR
Merge branch 'ccip-develop' into permissionless-token-pools-demo
fbda5e7
@RensR
Merge branch 'ccip-develop' into permissionless-token-pools-demo
208c889
@RensR
rm s_destPools
62d8b62
@RensR
improve MaybeRevertingBurnMintTokenPool
3325c86
@RensR
fix event generation
7b0a7f7
@RensR
Merge branch 'ccip-develop' into permissionless-token-pools-demo
8d73c06 
# Conflicts:
#	contracts/src/v0.8/ccip/offRamp/EVM2EVMOffRamp.sol
#	contracts/src/v0.8/ccip/onRamp/EVM2EVMOnRamp.sol
#	contracts/src/v0.8/ccip/pools/TokenPool.sol
#	contracts/src/v0.8/ccip/test/StructFactory.sol
#	contracts/src/v0.8/ccip/test/applications/ImmutableExample.t.sol
#	contracts/src/v0.8/ccip/test/e2e/End2End.t.sol
#	contracts/src/v0.8/ccip/test/offRamp/EVM2EVMOffRamp.t.sol
#	contracts/src/v0.8/ccip/test/offRamp/EVM2EVMOffRampSetup.t.sol
#	contracts/src/v0.8/ccip/test/onRamp/EVM2EVMOnRamp.t.sol
#	contracts/src/v0.8/ccip/test/pools/BurnMintTokenPool.t.sol
#	contracts/src/v0.8/ccip/test/pools/LockReleaseTokenPool.t.sol
#	contracts/src/v0.8/ccip/test/pools/USDCTokenPool.t.sol
@RensR
fix tests & solhint
1c15e67
@RensR
Update rebalancer.gas-snapshot
4ba8886
@RensR
refactor with more explicit arguments
6cd835a
@RensR
add tests for get/set pool
f50dca5
@RensR
increase coverage
c89ff60
@RensR
add tests and resolve todos
4367860
@RensR
add custom errors for the pool checks
85e7a66
@RensR
let the pool return the token on releaseOrMint
573e213
@RensR
golfing
a95c6a8
@RensR
add tests for get/set pool
e8e3892
@RensR
keep ccipSend event the same
a054ee4
@RensR
Gen wrappers for all token contract
9c73d96 
Create 1.4 versions of all in-use contracts so nothing breaks
@RensR
Merge branch 'ccip-develop' into permissionless-token-pools-demo
f35ca89
@RensR
init 1.5 onramp logic
0a1544f
@RensR
add getAllConfiguredTokens to registry
796c4d4
justinkaseman
justinkaseman commented Apr 11, 2024
View reviewed changes
contracts/src/v0.8/ccip/offRamp/EVM2EVMOffRamp.sol
@@ -496,8 +528,9 @@ contract EVM2EVMOffRamp is IAny2EVMOffRamp, AggregateRateLimiter, ITypeAndVersio
address receiver,
bytes[] memory encodedSourceTokenData,
bytes[] memory offchainTokenData
) internal returns (Client.EVMTokenAmount[] memory) {
Client.EVMTokenAmount[] memory destTokenAmounts = sourceTokenAmounts;
) internal returns (Client.EVMTokenAmount[] memory destTokenAmounts) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a named return saves some stack size

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 8642350 during Solidity Foundry #3627

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 488a841 during Solidity Foundry #3628

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit e6681d4 during Solidity Foundry #3629

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 95512b8 during Solidity Foundry #3630

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit a67cc61 during Solidity Foundry #3631

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 9a9e5a9 during Solidity Foundry #3633

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit a80a8b9 during Solidity Foundry #3635

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

@github-actions GitHub Actions
Copy link
Contributor

LCOV of commit 0704b11 during Solidity Foundry #3636

Summary coverage rate:
  lines......: 98.5% (968 of 983 lines)
  functions..: 95.9% (209 of 218 functions)
  branches...: 89.5% (374 of 418 branches)

Files changed coverage rate: n/a

⛔ The code coverage is too low: 98.47. Expected at least 98.5.

Base automatically changed from permissionless-token-pools-demo to ccip-develop April 12, 2024 08:44
@RensR
Copy link
Collaborator

RensR commented Apr 12, 2024

closed in favour of #714

@RensR RensR closed this Apr 12, 2024
@mateusz-sekara mateusz-sekara deleted the CCIP-1986-on-chain branch September 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR left review comments

@matYang matYang Awaiting requested review from matYang

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@jasonmci jasonmci Awaiting requested review from jasonmci

@dimkouv dimkouv Awaiting requested review from dimkouv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinkaseman @RensR @AnieeG @scheibinger