Add overall limit on sampled upkeeps #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infiloop2
changed the title
|
SonarQube Quality Gate
|
ferglor
approved these changes
Sep 5, 2023
| @@ -19,6 +19,8 @@ import ( | |||
| const ( | |||
| // This is the ticker interval for sampling conditional flow | |||
| SamplingConditionInterval = 3 * time.Second | |||
| // Maximum number of upkeeps to be sampled in every round | |||
| MaxSampledConditionals = 300 | |||
There was a problem hiding this comment.
If this isn't used outside this package I would lower case it so that it's not exported
There was a problem hiding this comment.
agree, but currently i would prefer to keep it consistent with other consts in package (which are also used just within the package but capitalised)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in smartcontractkit/chainlink#10485 we are putting overall limits on logs surfaced on every tick. Also putting a limit on conditionals samples done in a tick. We already have a random order defined on upkeeps, just put a limit on the total upkeeps we select
If number of required samples go above this, we should ideally log an error (not able to do right now with current logger). But the behaviour would be that the upkeeps would be bit delayed in getting sampled, rather than bombarding runner with a lot of checks which would affect log triggers too